CI: run tfplugindocs generate to address workflow failure
#2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BBBmau
commented
Aug 9, 2024
| @@ -88,7 +88,7 @@ Optional: | |||
| - `stabilization_window_seconds` (Number) Number of seconds for which past recommendations should be considered while scaling up or scaling down. This value must be greater than or equal to zero and less than or equal to 3600 (one hour). If not set, use the default values: - For scale up: 0 (i.e. no stabilization is done). - For scale down: 300 (i.e. the stabilization window is 300 seconds long). | |||
|
|
|||
| <a id="nestedblock--spec--behavior--scale_down--policy"></a> | |||
| ### Nested Schema for `spec.behavior.scale_down.policy` | |||
| ### Nested Schema for `spec.behavior.scale_down.stabilization_window_seconds` | |||
There was a problem hiding this comment.
Seems like this is an upstream tfplugindocs issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@sheneska It seems like we just need to run
tfplugindocs generateone more time off of main in order to prevent workflow failures on PRs.This PR just has the changes that were made when after running
tfplugindocs generateafter the recent commit.My understanding is the tfplugindocs generate should only find any docs that have yet to be generated (In the case where I used it it should've just found server_version but found some that haven't been generated.)
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note