Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): remove unused code #2161

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

thevilledev
Copy link
Contributor

Description

Remove code which is not referenced at all in the codebase. These seem like outdated helper functionality, leftovers from refactor or something related to old (deprecated) k8s versions. Impacts mostly test files.

Did not remove the unused function referenced on #2159 because it is required by the currently commented out test.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Based on this PR, I created a temp branch chore/remove-unused-with-acc-test which has the #2158 acceptance test fixes and then ran GHA for Kind. They pass. See full logs from here.

These tests pass as well:

        make website-lint
        make depscheck
        make fmtcheck
        make test
        make test-compile
        make tests-lint
        make vet

Release Note

Release note for CHANGELOG:

NONE

References

None

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@thevilledev thevilledev requested a review from a team as a code owner June 24, 2023 18:33
@BBBmau BBBmau merged commit d8885de into hashicorp:main Jul 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants