azurerm_*function_app, azurerm_linux_web_app - add node 22 and java 17 support for JBOSSEAP

[xiaxyi]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Add node 22 support for function app and java 17 support for JBOSSEAP for linux web app

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #28302
Fixes #28350

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[jackofallops]

Thanks @xiaxyi - Just one change to take a look at if you could, the rest I think is good to go.

[jackofallops]

Copy paste error here?

Suggested change

	Config: r.appStackNode(data, SkuBasicPlan, "22"),
	Check: acceptance.ComposeTestCheckFunc(
	check.That(data.ResourceName).ExistsInAzure(r),
	check.That(data.ResourceName).Key("kind").HasValue("functionapp,linux"),
	check.That(data.ResourceName).Key("site_config.0.linux_fx_version").HasValue("NODE|20"),
	Config: r.appStackNode(data, SkuBasicPlan, "22"),
	Check: acceptance.ComposeTestCheckFunc(
	check.That(data.ResourceName).ExistsInAzure(r),
	check.That(data.ResourceName).Key("kind").HasValue("functionapp,linux"),
	check.That(data.ResourceName).Key("site_config.0.linux_fx_version").HasValue("NODE|22"),

[xiaxyi]

Thanks @jackofallops for the comment, I fixed the typo.

[jackofallops]

Thanks @xiaxyi - LGTM now 👍

[orgads]

This still doesn't work. I found some missing spots: main...orgads:terraform-provider-azurerm:node-22

I don't know how to cover this in tests, so please take it from here.

[xiaxyi]

@orgads I don't think node 22 is supported for linux web app? At least the option seems not available in Azure portal?

Are you able to see node 22 for linux web app in Azure portal?

[orgads]

It doesn't appear for Flex Consumption, but it does for Consumption on both Linux and Windows.