azurerm_linux_virtual_machine and azurerm_windows_virtual_machine - only power off machines that are turned on

[jfsimoneau]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Only power off machines that are turned on before deleting them.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

I did not find how to create a new test with a powered-off VM.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_linux_virtual_machine and azurerm_windows_virtual_machine - Only power off running VMs [Operation ‘powerOff’ is not allowed (409 Conflict) #28218]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #28218

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[dlipovetsky]

Thanks for this!

This PR should be prioritized, because the bug it fixes is hit by the common workflow for creating a machine image:

1. Create VM using terraform.
2. Generalize the VM; one documented step is to deallocate the VM.
3. Create a machine image from the VM.
4. Destroy VM using terraform. This fails, because terraform tries to shutdown the VM, and it has already been deallocated.