Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove reamining use of deprecated strings.Title function and its linter exclusion #41089

Merged
merged 1 commit into from
Jan 27, 2025
Merged

chore: Remove reamining use of deprecated strings.Title function and its linter exclusion #41089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .ci/.golangci4.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ issues:
- linters:
- staticcheck
text: "SA1019: \\w+.\\w+ is deprecated: Use \\w+Context or \\w+WithoutTimeout instead"
# go: strings.Title
- linters:
- staticcheck
text: "SA1019: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0"
# Per-Service
- linters:
- staticcheck
Expand Down
4 changes: 2 additions & 2 deletions internal/service/workspaces/ip_group_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func testAccIPGroup_basic(t *testing.T) {
var v types.WorkspacesIpGroup
ipGroupName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
ipGroupNewName := sdkacctest.RandomWithPrefix("tf-acc-test-upd")
ipGroupDescription := fmt.Sprintf("Terraform Acceptance Test %s", strings.Title(sdkacctest.RandString(20)))
ipGroupDescription := fmt.Sprintf("Terraform Acceptance Test %s", sdkacctest.RandString(20))
resourceName := "aws_workspaces_ip_group.test"

resource.Test(t, resource.TestCase{
Expand Down Expand Up @@ -118,7 +118,7 @@ func testAccIPGroup_disappears(t *testing.T) {
ctx := acctest.Context(t)
var v types.WorkspacesIpGroup
ipGroupName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
ipGroupDescription := fmt.Sprintf("Terraform Acceptance Test %s", strings.Title(sdkacctest.RandString(20)))
ipGroupDescription := fmt.Sprintf("Terraform Acceptance Test %s", sdkacctest.RandString(20))
resourceName := "aws_workspaces_ip_group.test"

resource.Test(t, resource.TestCase{
Expand Down
Loading