-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add missing attributes to aws_ecs_task_definition data source #41081
feat: Add missing attributes to aws_ecs_task_definition data source #41081
Conversation
Community NoteVoting for Prioritization
For Submitters
|
5e1a31b
to
89203dc
Compare
89203dc
to
c402794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECSTaskDefinitionDataSource_' PKG=ecs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ecs/... -v -count 1 -parallel 3 -run=TestAccECSTaskDefinitionDataSource_ -timeout 360m -vet=off
2025/01/28 10:20:05 Initializing Terraform AWS Provider...
=== RUN TestAccECSTaskDefinitionDataSource_basic
=== PAUSE TestAccECSTaskDefinitionDataSource_basic
=== RUN TestAccECSTaskDefinitionDataSource_ec2
=== PAUSE TestAccECSTaskDefinitionDataSource_ec2
=== RUN TestAccECSTaskDefinitionDataSource_fargate
=== PAUSE TestAccECSTaskDefinitionDataSource_fargate
=== RUN TestAccECSTaskDefinitionDataSource_proxyConfiguration
=== PAUSE TestAccECSTaskDefinitionDataSource_proxyConfiguration
=== CONT TestAccECSTaskDefinitionDataSource_basic
=== CONT TestAccECSTaskDefinitionDataSource_fargate
=== CONT TestAccECSTaskDefinitionDataSource_proxyConfiguration
--- PASS: TestAccECSTaskDefinitionDataSource_fargate (11.66s)
=== CONT TestAccECSTaskDefinitionDataSource_ec2
--- PASS: TestAccECSTaskDefinitionDataSource_proxyConfiguration (11.67s)
--- PASS: TestAccECSTaskDefinitionDataSource_basic (12.90s)
--- PASS: TestAccECSTaskDefinitionDataSource_ec2 (12.13s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecs 29.469s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
This PR is to add the missing attributes (compared to the resource) for the
aws_ecs_task_definition
data source.Note that unit tests depend on #41078 because it needs the
enable_fault_injection
argument in the resource.Relations
Closes #40214
References
Referred to TaskDefinition for specs and wordings.
Output from Acceptance Testing