Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing attributes to aws_ecs_task_definition data source #41081

Merged

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented Jan 26, 2025

Description

This PR is to add the missing attributes (compared to the resource) for the aws_ecs_task_definition data source.

Note that unit tests depend on #41078 because it needs the enable_fault_injection argument in the resource.

Relations

Closes #40214

References

Referred to TaskDefinition for specs and wordings.

Output from Acceptance Testing

$ make testacc TESTS="TestAccECSTaskDefinitionDataSource_" PKG=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSTaskDefinitionDataSource_'  -timeout 360m -vet=off
2025/01/25 21:01:42 Initializing Terraform AWS Provider...
=== RUN   TestAccECSTaskDefinitionDataSource_basic
=== PAUSE TestAccECSTaskDefinitionDataSource_basic
=== RUN   TestAccECSTaskDefinitionDataSource_ec2
=== PAUSE TestAccECSTaskDefinitionDataSource_ec2
=== RUN   TestAccECSTaskDefinitionDataSource_fargate
=== PAUSE TestAccECSTaskDefinitionDataSource_fargate
=== RUN   TestAccECSTaskDefinitionDataSource_proxyConfiguration
=== PAUSE TestAccECSTaskDefinitionDataSource_proxyConfiguration
=== CONT  TestAccECSTaskDefinitionDataSource_basic
=== CONT  TestAccECSTaskDefinitionDataSource_fargate
=== CONT  TestAccECSTaskDefinitionDataSource_proxyConfiguration
=== CONT  TestAccECSTaskDefinitionDataSource_ec2

$

@acwwat acwwat requested a review from a team as a code owner January 26, 2025 02:33
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jan 26, 2025
@acwwat acwwat force-pushed the f-aws_ecs_task_definition-add_missing_attrs branch 3 times, most recently from 5e1a31b to 89203dc Compare January 26, 2025 02:58
@acwwat acwwat force-pushed the f-aws_ecs_task_definition-add_missing_attrs branch from 89203dc to c402794 Compare January 26, 2025 03:00
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 27, 2025
@ewbankkit ewbankkit self-assigned this Jan 28, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 28, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECSTaskDefinitionDataSource_' PKG=ecs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ecs/... -v -count 1 -parallel 3  -run=TestAccECSTaskDefinitionDataSource_ -timeout 360m -vet=off
2025/01/28 10:20:05 Initializing Terraform AWS Provider...
=== RUN   TestAccECSTaskDefinitionDataSource_basic
=== PAUSE TestAccECSTaskDefinitionDataSource_basic
=== RUN   TestAccECSTaskDefinitionDataSource_ec2
=== PAUSE TestAccECSTaskDefinitionDataSource_ec2
=== RUN   TestAccECSTaskDefinitionDataSource_fargate
=== PAUSE TestAccECSTaskDefinitionDataSource_fargate
=== RUN   TestAccECSTaskDefinitionDataSource_proxyConfiguration
=== PAUSE TestAccECSTaskDefinitionDataSource_proxyConfiguration
=== CONT  TestAccECSTaskDefinitionDataSource_basic
=== CONT  TestAccECSTaskDefinitionDataSource_fargate
=== CONT  TestAccECSTaskDefinitionDataSource_proxyConfiguration
--- PASS: TestAccECSTaskDefinitionDataSource_fargate (11.66s)
=== CONT  TestAccECSTaskDefinitionDataSource_ec2
--- PASS: TestAccECSTaskDefinitionDataSource_proxyConfiguration (11.67s)
--- PASS: TestAccECSTaskDefinitionDataSource_basic (12.90s)
--- PASS: TestAccECSTaskDefinitionDataSource_ec2 (12.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	29.469s

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 04bb1bf into hashicorp:main Jan 28, 2025
68 checks passed
@github-actions github-actions bot added this to the v5.85.0 milestone Jan 28, 2025
@acwwat acwwat deleted the f-aws_ecs_task_definition-add_missing_attrs branch February 3, 2025 19:05
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

This functionality has been released in v5.85.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data source/aws_ecs_task_definition
3 participants