Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws_dataexchange_job #40551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TSKnuhtsen
Copy link

Description

This PR adds a resource for aws_dataexchange_job

Relations

Closes #40418

Output from Acceptance Testing

thyge@u5f9f1f071ee45a:~/development/clone/terraform-provider-aws$ make testacc TESTS=TestAccDataExchangeJob_* PKG=dataexchange
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/dataexchange/... -v -count 1 -parallel 20 -run='TestAccDataExchangeJob_*'  -timeout 360m
2024/12/12 20:27:14 Initializing Terraform AWS Provider...
=== RUN   TestAccDataExchangeJob_importAssetsFromS3basic
=== PAUSE TestAccDataExchangeJob_importAssetsFromS3basic
=== RUN   TestAccDataExchangeJob_importAssetsFromS3PostponeStart
=== PAUSE TestAccDataExchangeJob_importAssetsFromS3PostponeStart
=== RUN   TestAccDataExchangeJob_exportAssetsToS3Basic
=== PAUSE TestAccDataExchangeJob_exportAssetsToS3Basic
=== RUN   TestAccDataExchangeJob_exportAssetsToSignedUrl
=== PAUSE TestAccDataExchangeJob_exportAssetsToSignedUrl
=== RUN   TestAccDataExchangeJob_importAssetFromSignedUrl
--- PASS: TestAccDataExchangeJob_importAssetFromSignedUrl (16.61s)
=== CONT  TestAccDataExchangeJob_importAssetsFromS3basic
=== CONT  TestAccDataExchangeJob_exportAssetsToS3Basic
=== CONT  TestAccDataExchangeJob_importAssetsFromS3PostponeStart
=== CONT  TestAccDataExchangeJob_exportAssetsToSignedUrl
--- PASS: TestAccDataExchangeJob_exportAssetsToSignedUrl (39.43s)
--- PASS: TestAccDataExchangeJob_exportAssetsToS3Basic (43.34s)
--- PASS: TestAccDataExchangeJob_importAssetsFromS3basic (35.67s)
--- PASS: TestAccDataExchangeJob_importAssetsFromS3PostponeStart (54.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange	87.759s
...

@TSKnuhtsen TSKnuhtsen requested a review from a team as a code owner December 13, 2024 03:33
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dataexchange Issues and PRs that pertain to the dataexchange service. needs-triage Waiting for first response or review from a maintainer. labels Dec 13, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-resource Introduces a new resource. service/dataexchange Issues and PRs that pertain to the dataexchange service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: AWS Data Exchange - Job & AWS Data Exchange - Event Action
2 participants