Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ecs_service: availability_zone_rebalancing attribute shouldn't have a default #40525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nina-nee
Copy link

Description

An attributed availability_zone_rebalancing that was introduced in PR #40225 is defined as an optional, but also has a default value. For configurations where this flag is not defined, plan with refresh=false results in a change that would add this attribute to the state - which is not what "optional" should mean.

Relations

Closes #40349

Output from Acceptance Testing

Local tests pass, but I do not have an AWS account I could use for acceptance testing at the moment, sorry.

…have a default

An attributed availability_zone_rebalancing that was introduced in PR hashicorp#40225
is defined as an optional, but also has a default value. For configurations
where this flag is not defined, plan with `refresh=false` results in
a change that would add this attribute to the state - which is not what
"optional" should mean.

This is to address hashicorp#40349
@nina-nee nina-nee requested a review from a team as a code owner December 11, 2024 14:09
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. needs-triage Waiting for first response or review from a maintainer. labels Dec 11, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @nina-nee 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: optional flag availability_zone_rebalancing results in lingering changes with refresh=false
2 participants