internal/framework/types: surface ARN validation errors

.changelog/40008.txt

@@ -0,0 +1,3 @@
+```release-note:note
+provider: validation of arguments implementing the custom `ARNType` will properly surface validation errors
+```

internal/framework/types/arn.go

@@ -52,12 +52,9 @@ func (t arnType) ValueFromString(_ context.Context, in types.String) (basetypes.
 		return ARNUnknown(), diags
 	}
 
-	valueString := in.ValueString()
-	if _, err := arn.Parse(valueString); err != nil {
-		return ARNUnknown(), diags // Must not return validation errors.
-	}
-
-	return ARNValue(valueString), diags
+	// The ValidateAttribute method will surface errors if the value is an invalid
+	// ARN. This method simply passes the value through.
+	return ARNValue(in.ValueString()), diags
 }
 
 func (t arnType) ValueFromTerraform(ctx context.Context, in tftypes.Value) (attr.Value, error) {

internal/framework/types/arn_test.go

@@ -36,7 +36,7 @@ func TestARNTypeValueFromTerraform(t *testing.T) {
 		},
 		"invalid ARN": {
 			val:      tftypes.NewValue(tftypes.String, "not ok"),
-			expected: fwtypes.ARNUnknown(),
+			expected: fwtypes.ARNValue("not ok"),
 		},
 	}