resource/aws_api_gateway_account: Properly support unregistration

[gdavison]

Description

An aws_api_gateway_account can be unregistered by clearing the cloudwatch_role_arn. Do that and add sweeper.

Output from Acceptance Testing

% make testacc PKG=apigateway TESTS='TestAccAPIGateway_serial/Account'

--- PASS: TestAccAPIGateway_serial (178.47s)
    --- PASS: TestAccAPIGateway_serial/Account (178.47s)
        --- PASS: TestAccAPIGateway_serial/Account/basic (178.47s)

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🚀

Just one potential suggestion on retaining the no-op destroy behavior as an opt-in feature.

[jar-b]

LGTM 🎉

% make testacc PKG=apigateway TESTS=TestAccAPIGateway_serial/Account/
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run='TestAccAPIGateway_serial/Account/'  -timeout 360m
2024/11/07 10:01:35 Initializing Terraform AWS Provider...
=== RUN   TestAccAPIGateway_serial
=== RUN   TestAccAPIGateway_serial/Account
=== RUN   TestAccAPIGateway_serial/Account/ResetOnDelete_true
=== RUN   TestAccAPIGateway_serial/Account/basic
=== RUN   TestAccAPIGateway_serial/Account/CloudwatchRoleARN_Value
=== RUN   TestAccAPIGateway_serial/Account/CloudwatchRoleARN_Empty
=== RUN   TestAccAPIGateway_serial/Account/FrameworkMigration_Basic
=== RUN   TestAccAPIGateway_serial/Account/FrameworkMigration_CloudwatchRoleARN
=== RUN   TestAccAPIGateway_serial/Account/ResetOnDelete_false
--- PASS: TestAccAPIGateway_serial (389.36s)
    --- PASS: TestAccAPIGateway_serial/Account (389.36s)
        --- PASS: TestAccAPIGateway_serial/Account/ResetOnDelete_true (74.08s)
        --- PASS: TestAccAPIGateway_serial/Account/basic (34.53s)
        --- PASS: TestAccAPIGateway_serial/Account/CloudwatchRoleARN_Value (81.50s)
        --- PASS: TestAccAPIGateway_serial/Account/CloudwatchRoleARN_Empty (45.07s)
        --- PASS: TestAccAPIGateway_serial/Account/FrameworkMigration_Basic (45.45s)
        --- PASS: TestAccAPIGateway_serial/Account/FrameworkMigration_CloudwatchRoleARN (64.17s)
        --- PASS: TestAccAPIGateway_serial/Account/ResetOnDelete_false (44.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 394.414s

[github-actions]

This functionality has been released in v5.75.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!