r/aws_iot_billing_group migration to Plugin Framework

[rainkwan]

Description

Updating IoT Billing Group to use Plugin Framework instead of Plugin SDKv2.

Output from Acceptance Testing

 make testacc PKG=iot TESTS=TestAccIoTBillingGroup_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTBillingGroup_'  -timeout 360m
2024/11/01 15:27:31 Initializing Terraform AWS Provider...
=== RUN   TestAccIoTBillingGroup_basic
=== PAUSE TestAccIoTBillingGroup_basic
=== RUN   TestAccIoTBillingGroup_disappears
=== PAUSE TestAccIoTBillingGroup_disappears
=== RUN   TestAccIoTBillingGroup_tags
=== PAUSE TestAccIoTBillingGroup_tags
=== RUN   TestAccIoTBillingGroup_properties
=== PAUSE TestAccIoTBillingGroup_properties
=== RUN   TestAccIoTBillingGroup_migrateFromPluginSDK
=== PAUSE TestAccIoTBillingGroup_migrateFromPluginSDK
=== RUN   TestAccIoTBillingGroup_migrateFromPluginSDK_properties
=== PAUSE TestAccIoTBillingGroup_migrateFromPluginSDK_properties
=== CONT  TestAccIoTBillingGroup_basic
=== CONT  TestAccIoTBillingGroup_properties
=== CONT  TestAccIoTBillingGroup_migrateFromPluginSDK_properties
=== CONT  TestAccIoTBillingGroup_migrateFromPluginSDK
=== CONT  TestAccIoTBillingGroup_disappears
=== CONT  TestAccIoTBillingGroup_tags
--- PASS: TestAccIoTBillingGroup_disappears (14.28s)
--- PASS: TestAccIoTBillingGroup_basic (16.41s)
--- PASS: TestAccIoTBillingGroup_properties (25.37s)
--- PASS: TestAccIoTBillingGroup_tags (32.28s)
--- PASS: TestAccIoTBillingGroup_migrateFromPluginSDK (35.45s)
--- PASS: TestAccIoTBillingGroup_migrateFromPluginSDK_properties (47.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        52.831s


...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @rainkwan 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[jar-b]

LGTM 🎉

% make testacc PKG=iot TESTS=TestAccIoTBillingGroup_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTBillingGroup_'  -timeout 360m
2024/11/04 10:13:32 Initializing Terraform AWS Provider...
=== RUN   TestAccIoTBillingGroup_basic
=== PAUSE TestAccIoTBillingGroup_basic
=== RUN   TestAccIoTBillingGroup_disappears
=== PAUSE TestAccIoTBillingGroup_disappears
=== RUN   TestAccIoTBillingGroup_tags
=== PAUSE TestAccIoTBillingGroup_tags
=== RUN   TestAccIoTBillingGroup_properties
=== PAUSE TestAccIoTBillingGroup_properties
=== RUN   TestAccIoTBillingGroup_migrateFromPluginSDK
=== PAUSE TestAccIoTBillingGroup_migrateFromPluginSDK
=== RUN   TestAccIoTBillingGroup_migrateFromPluginSDK_properties
=== PAUSE TestAccIoTBillingGroup_migrateFromPluginSDK_properties
=== CONT  TestAccIoTBillingGroup_basic
=== CONT  TestAccIoTBillingGroup_migrateFromPluginSDK_properties
=== CONT  TestAccIoTBillingGroup_properties
=== CONT  TestAccIoTBillingGroup_disappears
=== CONT  TestAccIoTBillingGroup_migrateFromPluginSDK
=== CONT  TestAccIoTBillingGroup_tags
--- PASS: TestAccIoTBillingGroup_disappears (17.02s)
--- PASS: TestAccIoTBillingGroup_basic (19.47s)
--- PASS: TestAccIoTBillingGroup_properties (27.54s)
--- PASS: TestAccIoTBillingGroup_tags (35.53s)
--- PASS: TestAccIoTBillingGroup_migrateFromPluginSDK (41.22s)
--- PASS: TestAccIoTBillingGroup_migrateFromPluginSDK_properties (44.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        49.143s

[jar-b]

Thanks for your contribution, @rainkwan! 👍

[github-actions]

This functionality has been released in v5.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!