Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: Add perfsprint #39975

Merged
merged 10 commits into from
Nov 4, 2024
Merged

linter: Add perfsprint #39975

merged 10 commits into from
Nov 4, 2024

Conversation

gdavison
Copy link
Contributor

Description

Adds linter perfsprint to catch uses of fmt.Sprint or fmt.Sprintf used for conversion to string when a direct call to, e.g. a strconv call can be used

@gdavison gdavison requested a review from a team as a code owner October 31, 2024 21:29
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. service/ec2 Issues and PRs that pertain to the ec2 service. service/apigateway Issues and PRs that pertain to the apigateway service. service/sns Issues and PRs that pertain to the sns service. service/rds Issues and PRs that pertain to the rds service. service/gamelift Issues and PRs that pertain to the gamelift service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/lightsail Issues and PRs that pertain to the lightsail service. service/sfn Issues and PRs that pertain to the sfn service. service/acmpca Issues and PRs that pertain to the acmpca service. service/pricing Issues and PRs that pertain to the pricing service. service/xray Issues and PRs that pertain to the xray service. service/fsx Issues and PRs that pertain to the fsx service. service/lakeformation Issues and PRs that pertain to the lakeformation service. linter Pertains to changes to or issues with the various linters. tags Pertains to resource tagging. service/events Issues and PRs that pertain to the events service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 31, 2024
jar-b
jar-b approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdavison gdavison merged commit 2af11d2 into main Nov 4, 2024
34 checks passed
@gdavison gdavison deleted the td-linter-perfsprint branch November 4, 2024 18:45
@github-actions github-actions bot added this to the v5.75.0 milestone Nov 4, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 4, 2024
Update CHANGELOG.md for #39975
ce96b72
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 11, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.75.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. service/acmpca Issues and PRs that pertain to the acmpca service. service/apigateway Issues and PRs that pertain to the apigateway service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/ec2 Issues and PRs that pertain to the ec2 service. service/events Issues and PRs that pertain to the events service. service/fsx Issues and PRs that pertain to the fsx service. service/gamelift Issues and PRs that pertain to the gamelift service. service/iam Issues and PRs that pertain to the iam service. service/lakeformation Issues and PRs that pertain to the lakeformation service. service/lightsail Issues and PRs that pertain to the lightsail service. service/pricing Issues and PRs that pertain to the pricing service. service/rds Issues and PRs that pertain to the rds service. service/sfn Issues and PRs that pertain to the sfn service. service/sns Issues and PRs that pertain to the sns service. service/xray Issues and PRs that pertain to the xray service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.75.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @jar-b