Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linting: Fixes to acceptance test linting #39426

Merged
merged 29 commits into from
Oct 1, 2024
Merged

linting: Fixes to acceptance test linting #39426

merged 29 commits into from
Oct 1, 2024

Conversation

gdavison
Copy link
Contributor

Description

Adds Terraform configuration linting with tflint and terraform fmt for acceptance tests using Terraform directories

Restores linting of Terraform configurations embedded in Go acceptance tests and documentation files.

@gdavison
Fixes aws_medialive_multiplex tf configs
840acec
@gdavison
Fixes terraform_deprecated_index
1ea15cf
@gdavison
Adds tflint-ignore: terraform_unused_declarations to data source te…
ec486ad 
…st configs
@gdavison
Removes unused data source
4069bd3
@gdavison
Removes unused rName variables
1414d13
@gdavison
Adds custom-linux-xl target for act
8c37829
@gdavison
Moves settings for terraform_required_providers and `terraform_requ…
e8fa1c0 
…ired_version` to `.tflint.hcl`
@gdavison
Uses --recursive to make a single call to tflint for examples
2091c1e
@gdavison
shellcheck
927ce6b
@gdavison
Updates examples tflint
5f693a0
@gdavison
acctest terraform_comment_syntax
fa2fe2c
@gdavison
acctest terraform_deprecated_lookup
5a70246
@gdavison
acctest terraform_deprecated_interpolation
552ea2c
@gdavison
All docs files were renamed to *.html.markdown. Also excludes `cd…
fc5725c 
…ktf` files
@gdavison
The tflint parameter to focus on a particular directory was changed…
0c58730 
… to `--chdir`
@gdavison
Documentation fixes
ccf41b4
@gdavison
aws_lambda_function_deprecated_runtime
9207408
@gdavison
Script fix
f767281
@gdavison
Adds tflint for acctest Terraform directories to makefile
03d5e52
@gdavison
Adds tflint for acctest Terraform directories to GitHub actions
23a3109
@gdavison
Separates GitHub actions for linting embedded Terraform configs and d…
9e448a1 
…irectories
@gdavison
Revert
9f8f250
@gdavison
Updates tflint AWS ruleset
00d64f9
@gdavison
Adds failures for testing
092089b
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. service/iam Issues and PRs that pertain to the iam service. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 20, 2024
@github-actions github-actions bot added service/appintegrations Issues and PRs that pertain to the appintegrations service. service/logs Issues and PRs that pertain to the logs service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/rekognition Issues and PRs that pertain to the rekognition service. service/vpc Issues and PRs that pertain to the vpc service. service/ivschat Issues and PRs that pertain to the ivschat service. service/pipes Issues and PRs that pertain to the pipes service. service/vpclattice Issues and PRs that pertain to the vpclattice service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/bedrock Issues and PRs that pertain to the bedrock service. service/datazone Issues and PRs that pertain to the datazone service. service/timestreaminfluxdb Issues and PRs that pertain to the timestreaminfluxdb service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Sep 20, 2024
@gdavison gdavison marked this pull request as ready for review September 20, 2024 21:35
ewbankkit
ewbankkit approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit ebc475d into main Oct 1, 2024
50 checks passed
@gdavison gdavison deleted the td-acctest-configdir-tflint branch October 1, 2024 20:28
@github-actions github-actions bot added this to the v5.70.0 milestone Oct 1, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@breathingdust breathingdust Awaiting requested review from breathingdust breathingdust is a code owner

@justinretzolk justinretzolk Awaiting requested review from justinretzolk justinretzolk is a code owner

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. generators Relates to code generators. github_actions Pull requests that update Github_actions code linter Pertains to changes to or issues with the various linters. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amp Issues and PRs that pertain to the amp service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appconfig Issues and PRs that pertain to the appconfig service. service/appflow Issues and PRs that pertain to the appflow service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/appmesh Issues and PRs that pertain to the appmesh service. service/appsync Issues and PRs that pertain to the appsync service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/bedrock Issues and PRs that pertain to the bedrock service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/configservice Issues and PRs that pertain to the configservice service. service/datazone Issues and PRs that pertain to the datazone service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/events Issues and PRs that pertain to the events service. service/firehose Issues and PRs that pertain to the firehose service. service/guardduty Issues and PRs that pertain to the guardduty service. service/iam Issues and PRs that pertain to the iam service. service/ivschat Issues and PRs that pertain to the ivschat service. service/kafka Issues and PRs that pertain to the kafka service. service/kendra Issues and PRs that pertain to the kendra service. service/kinesisanalytics Issues and PRs that pertain to the kinesisanalytics service. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. service/lambda Issues and PRs that pertain to the lambda service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/logs Issues and PRs that pertain to the logs service. service/medialive Issues and PRs that pertain to the medialive service. service/pinpoint Issues and PRs that pertain to the pinpoint service. service/pipes Issues and PRs that pertain to the pipes service. service/rds Issues and PRs that pertain to the rds service. service/rekognition Issues and PRs that pertain to the rekognition service. service/route53 Issues and PRs that pertain to the route53 service. service/s3 Issues and PRs that pertain to the s3 service. service/sagemaker Issues and PRs that pertain to the sagemaker service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/ses Issues and PRs that pertain to the ses service. service/sfn Issues and PRs that pertain to the sfn service. service/shield Issues and PRs that pertain to the shield service. service/sns Issues and PRs that pertain to the sns service. service/sqs Issues and PRs that pertain to the sqs service. service/ssm Issues and PRs that pertain to the ssm service. service/timestreaminfluxdb Issues and PRs that pertain to the timestreaminfluxdb service. service/vpc Issues and PRs that pertain to the vpc service. service/vpclattice Issues and PRs that pertain to the vpclattice service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.70.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit