-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/baws_mwaa_environment: fix customer managed endpoints pending state #39394
/baws_mwaa_environment: fix customer managed endpoints pending state #39394
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @alexbacchin 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
…rt customer managed endpoints
6c576fb
to
6282506
Compare
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccMWAAEnvironment_customerVPCE\|TestAccMWAAEnvironment_basic' PKG=mwaa
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/mwaa/... -v -count 1 -parallel 20 -run=TestAccMWAAEnvironment_customerVPCE\|TestAccMWAAEnvironment_basic -timeout 360m
=== RUN TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== RUN TestAccMWAAEnvironment_customerVPCE
=== PAUSE TestAccMWAAEnvironment_customerVPCE
=== CONT TestAccMWAAEnvironment_basic
=== CONT TestAccMWAAEnvironment_customerVPCE
--- PASS: TestAccMWAAEnvironment_customerVPCE (2024.12s)
--- PASS: TestAccMWAAEnvironment_basic (2402.82s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/mwaa 2408.213s
@alexbacchin Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR
PENDING
as a valid target state for aws_mwaa_environment whenendpoint_management="CUSTOMER"
. Ref: Managing your own Amazon VPC endpoints on Amazon MWAATestAccMWAAEnvironment_customer_vpce
Relations
Closes #39388
References
Output from Acceptance Testing