Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/baws_mwaa_environment: fix customer managed endpoints pending state #39394

Merged
merged 10 commits into from
Sep 19, 2024

Conversation

alexbacchin
Copy link
Contributor

@alexbacchin alexbacchin commented Sep 19, 2024

Description

This PR

  • adds PENDING as a valid target state for aws_mwaa_environment when endpoint_management="CUSTOMER". Ref: Managing your own Amazon VPC endpoints on Amazon MWAA
  • adds new acceptance test to cover the customer managed endpoint scenario TestAccMWAAEnvironment_customer_vpce

Relations

Closes #39388

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccMWAAEnvironment_customer_vpce PKG=mwaa
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/mwaa/... -v -count 1 -parallel 20 -run='TestAccMWAAEnvironment_customer_vpce'  -timeout 360m
=== RUN   TestAccMWAAEnvironment_customer_vpce
=== PAUSE TestAccMWAAEnvironment_customer_vpce
=== CONT  TestAccMWAAEnvironment_customer_vpce
--- PASS: TestAccMWAAEnvironment_customer_vpce (2166.22s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mwaa       2166.315s

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/mwaa Issues and PRs that pertain to the mwaa service. needs-triage Waiting for first response or review from a maintainer. labels Sep 19, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @alexbacchin 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@alexbacchin alexbacchin marked this pull request as ready for review September 19, 2024 10:51
@alexbacchin alexbacchin requested a review from a team as a code owner September 19, 2024 10:51
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 19, 2024
@ewbankkit ewbankkit self-assigned this Sep 19, 2024
@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Sep 19, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 19, 2024
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMWAAEnvironment_customerVPCE\|TestAccMWAAEnvironment_basic' PKG=mwaa
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/mwaa/... -v -count 1 -parallel 20  -run=TestAccMWAAEnvironment_customerVPCE\|TestAccMWAAEnvironment_basic -timeout 360m
=== RUN   TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== RUN   TestAccMWAAEnvironment_customerVPCE
=== PAUSE TestAccMWAAEnvironment_customerVPCE
=== CONT  TestAccMWAAEnvironment_basic
=== CONT  TestAccMWAAEnvironment_customerVPCE
--- PASS: TestAccMWAAEnvironment_customerVPCE (2024.12s)
--- PASS: TestAccMWAAEnvironment_basic (2402.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	2408.213s

@ewbankkit
Copy link
Contributor

@alexbacchin Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 68a9867 into hashicorp:main Sep 19, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.68.0 milestone Sep 19, 2024
Copy link

This functionality has been released in v5.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 20, 2024
@alexbacchin alexbacchin deleted the b-mwaa_env_customer_vpce branch September 24, 2024 10:27
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/mwaa Issues and PRs that pertain to the mwaa service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: MWAA Environment with customer managed endpoints error
2 participants