Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add aws_imagebuilder_lifecycle_policy & Tech debt: migrate imagebuilder resources to AWS SDK for Go v2 #35674

Open
wants to merge 113 commits into
base: main
Choose a base branch
from
Open

feat: add aws_imagebuilder_lifecycle_policy & Tech debt: migrate imagebuilder resources to AWS SDK for Go v2 #35674

wants to merge 113 commits into from

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Feb 6, 2024 •
edited
Loading

Description

Relations

Closes #34854
Closes #36148

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. and removed size/XL Managed by automation to categorize the size of a PR. labels Feb 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 6, 2024
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Feb 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the external-maintainer Contribution from a trusted external contributor. label Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 8, 2024
@bschaatsbergen bschaatsbergen changed the title feat: add aws_imagebuilder_lifecycle_policy feat: add aws_imagebuilder_lifecycle_policy & Tech debt: migrate imagebuilder resources to AWS SDK for Go v2 Feb 29, 2024
@github-actions github-actions bot added sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. labels Feb 29, 2024
@ewbankkit
d/aws_imagebuilder_infrastructure_configuration: Reduce visibility.
0efb770
@ewbankkit
d/aws_imagebuilder_infrastructure_configurations: Reduce visibility.
d0d38c9
@ewbankkit
r/aws_imagebuilder_image: Tidy up waiting.
893bb81
@ewbankkit
r/aws_imagebuilder_workflow: Reduce visibility.
b69fc23
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: Use AutoFlEx.
49214da
@ewbankkit
imagebuilder: Tidy up sweepers.
942ab4f
@ewbankkit
Add CHANGELOG entry.
efe4fea
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: 'policy_details' -> 'policy_deta…
e261457 
…il'.
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: 'include_resources' -> 'include_…
a5ea69b 
…resource'.
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: 'exclusion_rules' -> 'exclusion_…
0548869 
…rule'.
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: 'recipes' -> 'recipe'.
720c1bd
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: 'exclusion_rule' -> 'exclusion_r…
e86decf 
…ules'.
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: 'include_resource' -> 'include_r…
0969e5a 
…esources'.
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: Fixes after some testing.
8d7cfff
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: Use 'ParallelTest'.
3933223
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: 'policy_detail.action.include_re…
2ee5141 
…sources' defaults.
@ewbankkit
r/aws_imagebuilder_lifecycle_policy: Fixes after some more testing.
ce9651a
@ewbankkit
Acceptance test output:
7b6e117 
% make testacc TESTARGS='-run=TestAccImageBuilderLifecyclePolicy_' PKG=imagebuilder ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/imagebuilder/... -v -count 1 -parallel 3  -run=TestAccImageBuilderLifecyclePolicy_ -timeout 360m
=== RUN   TestAccImageBuilderLifecyclePolicy_basic
=== PAUSE TestAccImageBuilderLifecyclePolicy_basic
=== RUN   TestAccImageBuilderLifecyclePolicy_policyDetails
=== PAUSE TestAccImageBuilderLifecyclePolicy_policyDetails
=== RUN   TestAccImageBuilderLifecyclePolicy_resourceSelection
=== PAUSE TestAccImageBuilderLifecyclePolicy_resourceSelection
=== RUN   TestAccImageBuilderLifecyclePolicy_tags
=== PAUSE TestAccImageBuilderLifecyclePolicy_tags
=== RUN   TestAccImageBuilderLifecyclePolicy_disappears
=== PAUSE TestAccImageBuilderLifecyclePolicy_disappears
=== CONT  TestAccImageBuilderLifecyclePolicy_basic
=== CONT  TestAccImageBuilderLifecyclePolicy_tags
=== CONT  TestAccImageBuilderLifecyclePolicy_resourceSelection
--- PASS: TestAccImageBuilderLifecyclePolicy_basic (22.53s)
=== CONT  TestAccImageBuilderLifecyclePolicy_policyDetails
--- PASS: TestAccImageBuilderLifecyclePolicy_resourceSelection (31.12s)
=== CONT  TestAccImageBuilderLifecyclePolicy_disappears
--- PASS: TestAccImageBuilderLifecyclePolicy_tags (33.25s)
--- PASS: TestAccImageBuilderLifecyclePolicy_policyDetails (29.03s)
--- PASS: TestAccImageBuilderLifecyclePolicy_disappears (20.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	56.367s
@ewbankkit
imagebuilder: Use 'tfawserr.ErrCodeEquals', not 'errs.IsA'.
134e6df
@ewbankkit
Fix 'TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image'.
1af104e
@ewbankkit ewbankkit marked this pull request as ready for review August 6, 2024 17:27
@ewbankkit ewbankkit requested a review from a team as a code owner August 6, 2024 17:27
@ewbankkit
Copy link
Contributor 

% make testacc TESTARGS='-run=TestAccImageBuilder' PKG=imagebuilder ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/imagebuilder/... -v -count 1 -parallel 3  -run=TestAccImageBuilder -timeout 360m
=== RUN   TestAccImageBuilderComponentDataSource_arn
=== PAUSE TestAccImageBuilderComponentDataSource_arn
=== RUN   TestAccImageBuilderComponent_basic
=== PAUSE TestAccImageBuilderComponent_basic
=== RUN   TestAccImageBuilderComponent_disappears
=== PAUSE TestAccImageBuilderComponent_disappears
=== RUN   TestAccImageBuilderComponent_changeDescription
=== PAUSE TestAccImageBuilderComponent_changeDescription
=== RUN   TestAccImageBuilderComponent_description
=== PAUSE TestAccImageBuilderComponent_description
=== RUN   TestAccImageBuilderComponent_kmsKeyID
=== PAUSE TestAccImageBuilderComponent_kmsKeyID
=== RUN   TestAccImageBuilderComponent_Platform_windows
=== PAUSE TestAccImageBuilderComponent_Platform_windows
=== RUN   TestAccImageBuilderComponent_supportedOsVersions
=== PAUSE TestAccImageBuilderComponent_supportedOsVersions
=== RUN   TestAccImageBuilderComponent_tags
=== PAUSE TestAccImageBuilderComponent_tags
=== RUN   TestAccImageBuilderComponent_uri
=== PAUSE TestAccImageBuilderComponent_uri
=== RUN   TestAccImageBuilderComponentsDataSource_filter
=== PAUSE TestAccImageBuilderComponentsDataSource_filter
=== RUN   TestAccImageBuilderContainerRecipeDataSource_arn
=== PAUSE TestAccImageBuilderContainerRecipeDataSource_arn
=== RUN   TestAccImageBuilderContainerRecipe_basic
=== PAUSE TestAccImageBuilderContainerRecipe_basic
=== RUN   TestAccImageBuilderContainerRecipe_disappears
=== PAUSE TestAccImageBuilderContainerRecipe_disappears
=== RUN   TestAccImageBuilderContainerRecipe_component
=== PAUSE TestAccImageBuilderContainerRecipe_component
=== RUN   TestAccImageBuilderContainerRecipe_componentParameter
=== PAUSE TestAccImageBuilderContainerRecipe_componentParameter
=== RUN   TestAccImageBuilderContainerRecipe_description
=== PAUSE TestAccImageBuilderContainerRecipe_description
=== RUN   TestAccImageBuilderContainerRecipe_dockerfileTemplateURI
=== PAUSE TestAccImageBuilderContainerRecipe_dockerfileTemplateURI
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_deviceName
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_deviceName
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_deleteOnTermination
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_deleteOnTermination
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_encrypted
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_encrypted
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_iops
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_iops
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_kmsKeyID
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_kmsKeyID
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_snapshotID
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_snapshotID
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_throughput
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_throughput
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeSize
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeSize
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeType
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeType
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_noDevice
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_noDevice
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_virtualName
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_virtualName
=== RUN   TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image
=== PAUSE TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image
=== RUN   TestAccImageBuilderContainerRecipe_kmsKeyID
=== PAUSE TestAccImageBuilderContainerRecipe_kmsKeyID
=== RUN   TestAccImageBuilderContainerRecipe_tags
=== PAUSE TestAccImageBuilderContainerRecipe_tags
=== RUN   TestAccImageBuilderContainerRecipe_workingDirectory
=== PAUSE TestAccImageBuilderContainerRecipe_workingDirectory
=== RUN   TestAccImageBuilderContainerRecipe_platformOverride
=== PAUSE TestAccImageBuilderContainerRecipe_platformOverride
=== RUN   TestAccImageBuilderContainerRecipesDataSource_filter
=== PAUSE TestAccImageBuilderContainerRecipesDataSource_filter
=== RUN   TestAccImageBuilderDistributionConfigurationDataSource_arn
=== PAUSE TestAccImageBuilderDistributionConfigurationDataSource_arn
=== RUN   TestAccImageBuilderDistributionConfiguration_basic
=== PAUSE TestAccImageBuilderDistributionConfiguration_basic
=== RUN   TestAccImageBuilderDistributionConfiguration_disappears
=== PAUSE TestAccImageBuilderDistributionConfiguration_disappears
=== RUN   TestAccImageBuilderDistributionConfiguration_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_description
=== RUN   TestAccImageBuilderDistributionConfiguration_distribution
=== PAUSE TestAccImageBuilderDistributionConfiguration_distribution
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_organizationARNs
    distribution_configuration_test.go:353: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_organizationARNs (0.63s)
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_ouARNs
    distribution_configuration_test.go:386: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_ouARNs (0.14s)
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_enabled
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_enabled
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_launchTemplate
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_launchTemplate
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_maxParallelLaunches
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_maxParallelLaunches
=== RUN   TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_snapshotConfiguration
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_snapshotConfiguration
=== RUN   TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration
=== PAUSE TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration
=== RUN   TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== PAUSE TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
=== RUN   TestAccImageBuilderDistributionConfiguration_tags
=== PAUSE TestAccImageBuilderDistributionConfiguration_tags
=== RUN   TestAccImageBuilderDistributionConfigurationsDataSource_filter
=== PAUSE TestAccImageBuilderDistributionConfigurationsDataSource_filter
=== RUN   TestAccImageBuilderImageDataSource_ARN_aws
=== PAUSE TestAccImageBuilderImageDataSource_ARN_aws
=== RUN   TestAccImageBuilderImageDataSource_ARN_self
=== PAUSE TestAccImageBuilderImageDataSource_ARN_self
=== RUN   TestAccImageBuilderImageDataSource_ARN_containerRecipe
=== PAUSE TestAccImageBuilderImageDataSource_ARN_containerRecipe
=== RUN   TestAccImageBuilderImagePipelineDataSource_arn
=== PAUSE TestAccImageBuilderImagePipelineDataSource_arn
=== RUN   TestAccImageBuilderImagePipelineDataSource_containerRecipeARN
=== PAUSE TestAccImageBuilderImagePipelineDataSource_containerRecipeARN
=== RUN   TestAccImageBuilderImagePipeline_basic
=== PAUSE TestAccImageBuilderImagePipeline_basic
=== RUN   TestAccImageBuilderImagePipeline_disappears
=== PAUSE TestAccImageBuilderImagePipeline_disappears
=== RUN   TestAccImageBuilderImagePipeline_description
=== PAUSE TestAccImageBuilderImagePipeline_description
=== RUN   TestAccImageBuilderImagePipeline_distributionARN
=== PAUSE TestAccImageBuilderImagePipeline_distributionARN
=== RUN   TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== PAUSE TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
=== RUN   TestAccImageBuilderImagePipeline_imageRecipeARN
=== PAUSE TestAccImageBuilderImagePipeline_imageRecipeARN
=== RUN   TestAccImageBuilderImagePipeline_containerRecipeARN
=== PAUSE TestAccImageBuilderImagePipeline_containerRecipeARN
=== RUN   TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabled
=== PAUSE TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabled
=== RUN   TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabledAdvanced
=== PAUSE TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabledAdvanced
=== RUN   TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== PAUSE TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
=== RUN   TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== PAUSE TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
=== RUN   TestAccImageBuilderImagePipeline_infrastructureARN
=== PAUSE TestAccImageBuilderImagePipeline_infrastructureARN
=== RUN   TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== RUN   TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
=== RUN   TestAccImageBuilderImagePipeline_Schedule_timezone
=== PAUSE TestAccImageBuilderImagePipeline_Schedule_timezone
=== RUN   TestAccImageBuilderImagePipeline_status
=== PAUSE TestAccImageBuilderImagePipeline_status
=== RUN   TestAccImageBuilderImagePipeline_tags
=== PAUSE TestAccImageBuilderImagePipeline_tags
=== RUN   TestAccImageBuilderImagePipeline_workflow
=== PAUSE TestAccImageBuilderImagePipeline_workflow
=== RUN   TestAccImageBuilderImagePipeline_workflowParameter
=== PAUSE TestAccImageBuilderImagePipeline_workflowParameter
=== RUN   TestAccImageBuilderImagePipelinesDataSource_filter
=== PAUSE TestAccImageBuilderImagePipelinesDataSource_filter
=== RUN   TestAccImageBuilderImageRecipeDataSource_arn
=== PAUSE TestAccImageBuilderImageRecipeDataSource_arn
=== RUN   TestAccImageBuilderImageRecipe_basic
=== PAUSE TestAccImageBuilderImageRecipe_basic
=== RUN   TestAccImageBuilderImageRecipe_disappears
=== PAUSE TestAccImageBuilderImageRecipe_disappears
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMapping_deviceName
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMapping_deviceName
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_deleteOnTermination
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_deleteOnTermination
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_encrypted
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_encrypted
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_iops
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_iops
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_kmsKeyID
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_kmsKeyID
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_snapshotID
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_snapshotID
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_throughput
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_throughput
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeSize
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeSize
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP2
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP2
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP3
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP3
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMapping_noDevice
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMapping_noDevice
=== RUN   TestAccImageBuilderImageRecipe_BlockDeviceMapping_virtualName
=== PAUSE TestAccImageBuilderImageRecipe_BlockDeviceMapping_virtualName
=== RUN   TestAccImageBuilderImageRecipe_component
=== PAUSE TestAccImageBuilderImageRecipe_component
=== RUN   TestAccImageBuilderImageRecipe_componentParameter
=== PAUSE TestAccImageBuilderImageRecipe_componentParameter
=== RUN   TestAccImageBuilderImageRecipe_description
=== PAUSE TestAccImageBuilderImageRecipe_description
=== RUN   TestAccImageBuilderImageRecipe_tags
=== PAUSE TestAccImageBuilderImageRecipe_tags
=== RUN   TestAccImageBuilderImageRecipe_workingDirectory
=== PAUSE TestAccImageBuilderImageRecipe_workingDirectory
=== RUN   TestAccImageBuilderImageRecipe_pipelineUpdateDependency
=== PAUSE TestAccImageBuilderImageRecipe_pipelineUpdateDependency
=== RUN   TestAccImageBuilderImageRecipe_systemsManagerAgent
=== PAUSE TestAccImageBuilderImageRecipe_systemsManagerAgent
=== RUN   TestAccImageBuilderImageRecipe_updateDependency
=== PAUSE TestAccImageBuilderImageRecipe_updateDependency
=== RUN   TestAccImageBuilderImageRecipe_userDataBase64
=== PAUSE TestAccImageBuilderImageRecipe_userDataBase64
=== RUN   TestAccImageBuilderImageRecipe_windowsBaseImage
=== PAUSE TestAccImageBuilderImageRecipe_windowsBaseImage
=== RUN   TestAccImageBuilderImageRecipesDataSource_owner
=== PAUSE TestAccImageBuilderImageRecipesDataSource_owner
=== RUN   TestAccImageBuilderImageRecipesDataSource_filter
=== PAUSE TestAccImageBuilderImageRecipesDataSource_filter
=== RUN   TestAccImageBuilderImage_basic
=== PAUSE TestAccImageBuilderImage_basic
=== RUN   TestAccImageBuilderImage_disappears
=== PAUSE TestAccImageBuilderImage_disappears
=== RUN   TestAccImageBuilderImage_distributionARN
=== PAUSE TestAccImageBuilderImage_distributionARN
=== RUN   TestAccImageBuilderImage_enhancedImageMetadataEnabled
=== PAUSE TestAccImageBuilderImage_enhancedImageMetadataEnabled
=== RUN   TestAccImageBuilderImage_ImageTests_imageTestsEnabled
=== PAUSE TestAccImageBuilderImage_ImageTests_imageTestsEnabled
=== RUN   TestAccImageBuilderImage_ImageTests_timeoutMinutes
=== PAUSE TestAccImageBuilderImage_ImageTests_timeoutMinutes
=== RUN   TestAccImageBuilderImage_tags
=== PAUSE TestAccImageBuilderImage_tags
=== RUN   TestAccImageBuilderImage_containerRecipeARN
=== PAUSE TestAccImageBuilderImage_containerRecipeARN
=== RUN   TestAccImageBuilderImage_imageScanningConfiguration
=== PAUSE TestAccImageBuilderImage_imageScanningConfiguration
=== RUN   TestAccImageBuilderImage_outputResources_containers
=== PAUSE TestAccImageBuilderImage_outputResources_containers
=== RUN   TestAccImageBuilderImage_workflows
=== PAUSE TestAccImageBuilderImage_workflows
=== RUN   TestAccImageBuilderInfrastructureConfigurationDataSource_arn
=== PAUSE TestAccImageBuilderInfrastructureConfigurationDataSource_arn
=== RUN   TestAccImageBuilderInfrastructureConfiguration_basic
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_basic
=== RUN   TestAccImageBuilderInfrastructureConfiguration_disappears
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_disappears
=== RUN   TestAccImageBuilderInfrastructureConfiguration_description
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_description
=== RUN   TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions
=== RUN   TestAccImageBuilderInfrastructureConfiguration_instanceProfileName
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_instanceProfileName
=== RUN   TestAccImageBuilderInfrastructureConfiguration_instanceTypes
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_instanceTypes
=== RUN   TestAccImageBuilderInfrastructureConfiguration_keyPair
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_keyPair
=== RUN   TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName
=== RUN   TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix
=== RUN   TestAccImageBuilderInfrastructureConfiguration_resourceTags
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_resourceTags
=== RUN   TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs
=== RUN   TestAccImageBuilderInfrastructureConfiguration_snsTopicARN
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_snsTopicARN
=== RUN   TestAccImageBuilderInfrastructureConfiguration_subnetID
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_subnetID
=== RUN   TestAccImageBuilderInfrastructureConfiguration_tags
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_tags
=== RUN   TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure
=== PAUSE TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure
=== RUN   TestAccImageBuilderInfrastructureConfigurationsDataSource_filter
=== PAUSE TestAccImageBuilderInfrastructureConfigurationsDataSource_filter
=== RUN   TestAccImageBuilderLifecyclePolicy_basic
=== PAUSE TestAccImageBuilderLifecyclePolicy_basic
=== RUN   TestAccImageBuilderLifecyclePolicy_policyDetails
=== PAUSE TestAccImageBuilderLifecyclePolicy_policyDetails
=== RUN   TestAccImageBuilderLifecyclePolicy_resourceSelection
=== PAUSE TestAccImageBuilderLifecyclePolicy_resourceSelection
=== RUN   TestAccImageBuilderLifecyclePolicy_tags
=== PAUSE TestAccImageBuilderLifecyclePolicy_tags
=== RUN   TestAccImageBuilderLifecyclePolicy_disappears
=== PAUSE TestAccImageBuilderLifecyclePolicy_disappears
=== RUN   TestAccImageBuilderWorkflow_basic
=== PAUSE TestAccImageBuilderWorkflow_basic
=== RUN   TestAccImageBuilderWorkflow_disappears
=== PAUSE TestAccImageBuilderWorkflow_disappears
=== RUN   TestAccImageBuilderWorkflow_changeDescription
=== PAUSE TestAccImageBuilderWorkflow_changeDescription
=== RUN   TestAccImageBuilderWorkflow_description
=== PAUSE TestAccImageBuilderWorkflow_description
=== RUN   TestAccImageBuilderWorkflow_kmsKeyID
=== PAUSE TestAccImageBuilderWorkflow_kmsKeyID
=== RUN   TestAccImageBuilderWorkflow_tags
=== PAUSE TestAccImageBuilderWorkflow_tags
=== RUN   TestAccImageBuilderWorkflow_uri
=== PAUSE TestAccImageBuilderWorkflow_uri
=== CONT  TestAccImageBuilderComponentDataSource_arn
=== CONT  TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition
=== CONT  TestAccImageBuilderImage_enhancedImageMetadataEnabled
--- PASS: TestAccImageBuilderComponentDataSource_arn (12.01s)
=== CONT  TestAccImageBuilderDistributionConfiguration_description
--- PASS: TestAccImageBuilderDistributionConfiguration_description (18.77s)
=== CONT  TestAccImageBuilderImagePipeline_infrastructureARN
--- PASS: TestAccImageBuilderImagePipeline_Schedule_pipelineExecutionStartCondition (34.41s)
=== CONT  TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes
--- PASS: TestAccImageBuilderImagePipeline_infrastructureARN (33.48s)
=== CONT  TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_imageTestsEnabled (32.94s)
=== CONT  TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabledAdvanced
--- PASS: TestAccImageBuilderImagePipeline_ImageTests_timeoutMinutes (63.54s)
=== CONT  TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabled
=== NAME  TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabledAdvanced
    acctest.go:1715: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating Image Builder Image Pipeline: operation error imagebuilder: CreateImagePipeline, https response error StatusCode: 400, RequestID: 74bd5907-7d2c-4d6a-9cb9-19873e822956, api error ResourceDependencyException: Resource dependency error: Amazon Inspector is not enabled for 'ecr' resources in account '123456789012'.
        
          with aws_imagebuilder_image_pipeline.test,
          on terraform_plugin_test.tf line 105, in resource "aws_imagebuilder_image_pipeline" "test":
         105: resource "aws_imagebuilder_image_pipeline" "test" {
        
=== CONT  TestAccImageBuilderImagePipeline_containerRecipeARN
--- SKIP: TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabledAdvanced (15.82s)
=== NAME  TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabled
    acctest.go:1715: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: updating Image Builder Image Pipeline (arn:aws:imagebuilder:us-west-2:123456789012:image-pipeline/tf-acc-test-9170123398718304056): operation error imagebuilder: UpdateImagePipeline, https response error StatusCode: 400, RequestID: cffce478-1401-4daf-a8dd-6cd1d8a911b5, api error ResourceDependencyException: Resource dependency error: Amazon Inspector is not enabled for 'ec2' resources in account '123456789012'.
        
          with aws_imagebuilder_image_pipeline.test,
          on terraform_plugin_test.tf line 105, in resource "aws_imagebuilder_image_pipeline" "test":
         105: resource "aws_imagebuilder_image_pipeline" "test" {
        
--- SKIP: TestAccImageBuilderImagePipeline_ImageScanning_imageScanningEnabled (28.15s)
=== CONT  TestAccImageBuilderImagePipeline_imageRecipeARN
--- PASS: TestAccImageBuilderImagePipeline_containerRecipeARN (35.71s)
=== CONT  TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled
--- PASS: TestAccImageBuilderImagePipeline_imageRecipeARN (34.20s)
=== CONT  TestAccImageBuilderImagePipeline_distributionARN
--- PASS: TestAccImageBuilderImagePipeline_enhancedImageMetadataEnabled (36.38s)
=== CONT  TestAccImageBuilderImagePipeline_description
--- PASS: TestAccImageBuilderImagePipeline_distributionARN (38.11s)
=== CONT  TestAccImageBuilderImagePipeline_disappears
--- PASS: TestAccImageBuilderImagePipeline_description (35.06s)
=== CONT  TestAccImageBuilderImagePipeline_basic
--- PASS: TestAccImageBuilderImagePipeline_disappears (23.66s)
=== CONT  TestAccImageBuilderImagePipelineDataSource_containerRecipeARN
    acctest.go:1715: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating Image Builder Image Pipeline: operation error imagebuilder: CreateImagePipeline, https response error StatusCode: 400, RequestID: 23ca11f6-6117-4c19-802b-767e0b40798f, api error ResourceDependencyException: Resource dependency error: Amazon Inspector is not enabled for 'ecr' resources in account '123456789012'.
        
          with aws_imagebuilder_image_pipeline.test,
          on terraform_plugin_test.tf line 87, in resource "aws_imagebuilder_image_pipeline" "test":
          87: resource "aws_imagebuilder_image_pipeline" "test" {
        
--- SKIP: TestAccImageBuilderImagePipelineDataSource_containerRecipeARN (17.03s)
=== CONT  TestAccImageBuilderImagePipelineDataSource_arn
--- PASS: TestAccImageBuilderImagePipeline_basic (24.31s)
=== CONT  TestAccImageBuilderImageDataSource_ARN_containerRecipe
--- PASS: TestAccImageBuilderImagePipelineDataSource_arn (22.19s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description
=== NAME  TestAccImageBuilderImageDataSource_ARN_containerRecipe
    acctest.go:1715: skipping test for aws/us-west-2: Error running apply: exit status 1
        
        Error: creating Image Builder Image: operation error imagebuilder: CreateImage, https response error StatusCode: 400, RequestID: 8155d75f-f5a0-4de7-b64d-bcd4004c476b, api error ResourceDependencyException: Resource dependency error: Amazon Inspector is not enabled for 'ecr' resources in account '123456789012'.
        
          with aws_imagebuilder_image.test,
          on terraform_plugin_test.tf line 131, in resource "aws_imagebuilder_image" "test":
         131: resource "aws_imagebuilder_image" "test" {
        
--- SKIP: TestAccImageBuilderImageDataSource_ARN_containerRecipe (24.86s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_description (18.78s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_containerTags (18.86s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_targetAccountIDs (18.36s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name (26.20s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userIDs (18.46s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistributionLaunchPermission_userGroups (11.66s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionContainerDistribution_targetRepository (18.49s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_kmsKeyID (21.62s)
=== CONT  TestAccImageBuilderImageDataSource_ARN_self
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_description (19.26s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_amiTags (18.75s)
=== CONT  TestAccImageBuilderImageDataSource_ARN_aws
--- PASS: TestAccImageBuilderImageDataSource_ARN_aws (7.10s)
=== CONT  TestAccImageBuilderDistributionConfiguration_distribution
--- PASS: TestAccImageBuilderDistributionConfiguration_distribution (16.23s)
=== CONT  TestAccImageBuilderDistributionConfigurationsDataSource_filter
--- PASS: TestAccImageBuilderDistributionConfigurationsDataSource_filter (10.09s)
=== CONT  TestAccImageBuilderDistributionConfiguration_tags
--- PASS: TestAccImageBuilderDistributionConfiguration_tags (28.20s)
=== CONT  TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs
--- PASS: TestAccImageBuilderDistributionConfiguration_Distribution_licenseARNs (21.62s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP2
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP2 (14.49s)
=== CONT  TestAccImageBuilderImage_distributionARN
--- PASS: TestAccImageBuilderImage_enhancedImageMetadataEnabled (713.91s)
=== CONT  TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration
    distribution_configuration_test.go:790: Step 3/4 error: After applying this test step, the refresh plan was not empty.
        stdout
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_imagebuilder_distribution_configuration.test will be updated in-place
          ~ resource "aws_imagebuilder_distribution_configuration" "test" {
                id           = "arn:aws:imagebuilder:us-west-2:123456789012:distribution-configuration/tf-acc-test-6387447549501072938"
                name         = "tf-acc-test-6387447549501072938"
                tags         = {}
                # (5 unchanged attributes hidden)
        
              - distribution {
                  - license_configuration_arns = [] -> null
                  - region                     = "us-west-2" -> null
        
                  - launch_template_configuration {
                      - account_id         = "123456789012" -> null
                      - default            = true -> null
                      - launch_template_id = "lt-0503de24b8096d31a" -> null
                    }
                }
              + distribution {
                  + license_configuration_arns = []
                  + region                     = "us-west-2"
        
                  + launch_template_configuration {
                      + account_id         = "123456789012"
                      + default            = false
                      + launch_template_id = "lt-0503de24b8096d31a"
                    }
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccImageBuilderDistributionConfiguration_Distribution_launchTemplateConfiguration (23.21s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_snapshotConfiguration
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_snapshotConfiguration (19.10s)
=== CONT  TestAccImageBuilderImage_disappears
--- PASS: TestAccImageBuilderImageDataSource_ARN_self (764.49s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_maxParallelLaunches
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_maxParallelLaunches (20.34s)
=== CONT  TestAccImageBuilderImage_basic
--- PASS: TestAccImageBuilderImage_distributionARN (951.55s)
=== CONT  TestAccImageBuilderImageRecipesDataSource_filter
--- PASS: TestAccImageBuilderImageRecipesDataSource_filter (13.62s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_enabled
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_enabled (19.35s)
=== CONT  TestAccImageBuilderImageRecipesDataSource_owner
--- PASS: TestAccImageBuilderImageRecipesDataSource_owner (14.60s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_deleteOnTermination
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_deleteOnTermination (16.95s)
=== CONT  TestAccImageBuilderImageRecipe_windowsBaseImage
--- PASS: TestAccImageBuilderImageRecipe_windowsBaseImage (16.28s)
=== CONT  TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_launchTemplate
--- PASS: TestAccImageBuilderImage_disappears (752.84s)
=== CONT  TestAccImageBuilderImageRecipe_userDataBase64
--- PASS: TestAccImageBuilderImageRecipe_userDataBase64 (15.04s)
=== CONT  TestAccImageBuilderDistributionConfiguration_disappears
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionFastLaunchConfiguration_launchTemplate (24.32s)
=== CONT  TestAccImageBuilderDistributionConfiguration_basic
--- PASS: TestAccImageBuilderDistributionConfiguration_disappears (10.14s)
=== CONT  TestAccImageBuilderDistributionConfigurationDataSource_arn
    distribution_configuration_data_source_test.go:22: Step 1/1 error: Check failed: Check 23/27 error: data.aws_imagebuilder_distribution_configuration.test: Attribute 'distribution.0.launch_template_configuration.0.default' expected "false", got "true"
--- PASS: TestAccImageBuilderDistributionConfiguration_basic (12.19s)
=== CONT  TestAccImageBuilderContainerRecipesDataSource_filter
--- FAIL: TestAccImageBuilderDistributionConfigurationDataSource_arn (8.44s)
=== CONT  TestAccImageBuilderContainerRecipe_platformOverride
--- PASS: TestAccImageBuilderContainerRecipesDataSource_filter (14.20s)
=== CONT  TestAccImageBuilderContainerRecipe_workingDirectory
--- PASS: TestAccImageBuilderContainerRecipe_platformOverride (15.18s)
=== CONT  TestAccImageBuilderContainerRecipe_tags
--- PASS: TestAccImageBuilderContainerRecipe_workingDirectory (15.18s)
=== CONT  TestAccImageBuilderContainerRecipe_kmsKeyID
--- PASS: TestAccImageBuilderContainerRecipe_kmsKeyID (15.21s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image
--- PASS: TestAccImageBuilderContainerRecipe_tags (35.48s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_virtualName
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_Image (50.93s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_noDevice
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_virtualName (16.42s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeType
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_noDevice (15.41s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeSize
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeType (15.10s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_throughput
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_volumeSize (16.72s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_snapshotID
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_throughput (16.02s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_kmsKeyID
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_kmsKeyID (16.49s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_iops
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_iops (15.79s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_encrypted
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_encrypted (15.37s)
=== CONT  TestAccImageBuilderLifecyclePolicy_tags
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMappingEBS_snapshotID (90.90s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs
--- PASS: TestAccImageBuilderLifecyclePolicy_tags (37.49s)
=== CONT  TestAccImageBuilderImageRecipe_updateDependency
--- PASS: TestAccImageBuilderImageRecipe_updateDependency (26.72s)
=== CONT  TestAccImageBuilderWorkflow_uri
--- PASS: TestAccImageBuilderInfrastructureConfiguration_securityGroupIDs (34.86s)
=== CONT  TestAccImageBuilderWorkflow_tags
--- PASS: TestAccImageBuilderWorkflow_uri (18.99s)
=== CONT  TestAccImageBuilderWorkflow_kmsKeyID
--- PASS: TestAccImageBuilderWorkflow_tags (30.62s)
=== CONT  TestAccImageBuilderWorkflow_description
--- PASS: TestAccImageBuilderWorkflow_kmsKeyID (14.99s)
=== CONT  TestAccImageBuilderWorkflow_changeDescription
--- PASS: TestAccImageBuilderWorkflow_description (13.26s)
=== CONT  TestAccImageBuilderWorkflow_disappears
--- PASS: TestAccImageBuilderWorkflow_changeDescription (13.73s)
=== CONT  TestAccImageBuilderWorkflow_basic
--- PASS: TestAccImageBuilderWorkflow_disappears (11.07s)
=== CONT  TestAccImageBuilderLifecyclePolicy_disappears
--- PASS: TestAccImageBuilderWorkflow_basic (13.93s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure
--- PASS: TestAccImageBuilderLifecyclePolicy_disappears (20.27s)
=== CONT  TestAccImageBuilderLifecyclePolicy_policyDetails
--- PASS: TestAccImageBuilderInfrastructureConfiguration_terminateInstanceOnFailure (30.04s)
=== CONT  TestAccImageBuilderLifecyclePolicy_basic
--- PASS: TestAccImageBuilderLifecyclePolicy_policyDetails (29.57s)
=== CONT  TestAccImageBuilderInfrastructureConfigurationsDataSource_filter
--- PASS: TestAccImageBuilderLifecyclePolicy_basic (18.25s)
=== CONT  TestAccImageBuilderImageRecipeDataSource_arn
--- PASS: TestAccImageBuilderImageRecipeDataSource_arn (13.87s)
=== CONT  TestAccImageBuilderImageRecipe_basic
--- PASS: TestAccImageBuilderInfrastructureConfigurationsDataSource_filter (19.54s)
=== CONT  TestAccImageBuilderImagePipeline_status
--- PASS: TestAccImageBuilderImageRecipe_basic (15.09s)
=== CONT  TestAccImageBuilderImagePipeline_tags
--- PASS: TestAccImageBuilderImagePipeline_status (33.63s)
=== CONT  TestAccImageBuilderComponentsDataSource_filter
--- PASS: TestAccImageBuilderComponentsDataSource_filter (17.26s)
=== CONT  TestAccImageBuilderImagePipeline_workflow
--- PASS: TestAccImageBuilderImagePipeline_tags (43.47s)
=== CONT  TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_deviceName
--- PASS: TestAccImageBuilderContainerRecipe_InstanceConfiguration_BlockDeviceMapping_deviceName (17.02s)
=== CONT  TestAccImageBuilderImageRecipe_systemsManagerAgent
--- PASS: TestAccImageBuilderImagePipeline_workflow (33.33s)
=== CONT  TestAccImageBuilderImageRecipe_pipelineUpdateDependency
--- PASS: TestAccImageBuilderImageRecipe_systemsManagerAgent (15.17s)
=== CONT  TestAccImageBuilderContainerRecipe_dockerfileTemplateURI
--- PASS: TestAccImageBuilderContainerRecipe_dockerfileTemplateURI (20.15s)
=== CONT  TestAccImageBuilderImageRecipe_workingDirectory
--- PASS: TestAccImageBuilderImageRecipe_pipelineUpdateDependency (31.81s)
=== CONT  TestAccImageBuilderContainerRecipe_description
--- PASS: TestAccImageBuilderImageRecipe_workingDirectory (14.86s)
=== CONT  TestAccImageBuilderImageRecipe_tags
--- PASS: TestAccImageBuilderContainerRecipe_description (15.11s)
=== CONT  TestAccImageBuilderContainerRecipe_componentParameter
--- PASS: TestAccImageBuilderContainerRecipe_componentParameter (16.55s)
=== CONT  TestAccImageBuilderContainerRecipe_component
--- PASS: TestAccImageBuilderImage_basic (898.65s)
=== CONT  TestAccImageBuilderContainerRecipe_disappears
--- PASS: TestAccImageBuilderImageRecipe_tags (33.30s)
=== CONT  TestAccImageBuilderContainerRecipe_basic
--- PASS: TestAccImageBuilderContainerRecipe_component (16.18s)
=== CONT  TestAccImageBuilderContainerRecipeDataSource_arn
--- PASS: TestAccImageBuilderContainerRecipe_disappears (13.74s)
=== CONT  TestAccImageBuilderImageRecipe_disappears
--- PASS: TestAccImageBuilderContainerRecipe_basic (16.41s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_iops
--- PASS: TestAccImageBuilderContainerRecipeDataSource_arn (14.72s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_kmsKeyID
--- PASS: TestAccImageBuilderImageRecipe_disappears (13.79s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_snapshotID
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_iops (14.52s)
=== CONT  TestAccImageBuilderImagePipeline_workflowParameter
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_kmsKeyID (16.31s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_subnetID
--- PASS: TestAccImageBuilderImagePipeline_workflowParameter (31.40s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_tags
--- PASS: TestAccImageBuilderInfrastructureConfiguration_subnetID (33.66s)
=== CONT  TestAccImageBuilderLifecyclePolicy_resourceSelection
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_snapshotID (51.46s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_snsTopicARN
--- PASS: TestAccImageBuilderInfrastructureConfiguration_tags (33.64s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeSize
--- PASS: TestAccImageBuilderInfrastructureConfiguration_snsTopicARN (28.41s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMapping_virtualName
--- PASS: TestAccImageBuilderLifecyclePolicy_resourceSelection (32.40s)
=== CONT  TestAccImageBuilderImageRecipe_componentParameter
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeSize (14.17s)
=== CONT  TestAccImageBuilderImageRecipe_component
--- PASS: TestAccImageBuilderImageRecipe_componentParameter (12.77s)
=== CONT  TestAccImageBuilderImagePipelinesDataSource_filter
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMapping_virtualName (14.22s)
=== CONT  TestAccImageBuilderImageRecipe_description
--- PASS: TestAccImageBuilderImageRecipe_component (17.96s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_disappears
--- PASS: TestAccImageBuilderImageRecipe_description (14.52s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMapping_noDevice
--- PASS: TestAccImageBuilderImagePipelinesDataSource_filter (23.19s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_resourceTags
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMapping_noDevice (15.22s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP3
--- PASS: TestAccImageBuilderInfrastructureConfiguration_disappears (20.45s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_volumeTypeGP3 (14.64s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_instanceTypes
--- PASS: TestAccImageBuilderInfrastructureConfiguration_resourceTags (29.67s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_instanceProfileName
--- PASS: TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3KeyPrefix (32.64s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceTypes (32.72s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_keyPair
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceProfileName (39.02s)
=== CONT  TestAccImageBuilderComponent_changeDescription
--- PASS: TestAccImageBuilderInfrastructureConfiguration_LoggingS3Logs_s3BucketName (33.59s)
=== CONT  TestAccImageBuilderComponent_description
--- PASS: TestAccImageBuilderComponent_changeDescription (13.66s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_throughput
--- PASS: TestAccImageBuilderInfrastructureConfiguration_keyPair (30.80s)
=== CONT  TestAccImageBuilderInfrastructureConfigurationDataSource_arn
--- PASS: TestAccImageBuilderComponent_description (14.02s)
=== CONT  TestAccImageBuilderImage_workflows
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_throughput (15.08s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_basic
--- PASS: TestAccImageBuilderInfrastructureConfigurationDataSource_arn (20.85s)
=== CONT  TestAccImageBuilderImage_outputResources_containers
--- PASS: TestAccImageBuilderInfrastructureConfiguration_basic (22.24s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions
--- PASS: TestAccImageBuilderInfrastructureConfiguration_instanceMetadataOptions (23.85s)
=== CONT  TestAccImageBuilderComponent_tags
--- PASS: TestAccImageBuilderComponent_tags (31.61s)
=== CONT  TestAccImageBuilderImagePipeline_Schedule_scheduleExpression
--- PASS: TestAccImageBuilderImagePipeline_Schedule_scheduleExpression (35.18s)
=== CONT  TestAccImageBuilderComponent_uri
--- PASS: TestAccImageBuilderComponent_uri (21.09s)
=== CONT  TestAccImageBuilderComponent_disappears
--- PASS: TestAccImageBuilderComponent_disappears (11.62s)
=== CONT  TestAccImageBuilderComponent_Platform_windows
--- PASS: TestAccImageBuilderComponent_Platform_windows (13.67s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_deleteOnTermination
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_deleteOnTermination (15.35s)
=== CONT  TestAccImageBuilderComponent_basic
--- PASS: TestAccImageBuilderComponent_basic (14.23s)
=== CONT  TestAccImageBuilderImage_tags
--- PASS: TestAccImageBuilderImage_outputResources_containers (496.69s)
=== CONT  TestAccImageBuilderImage_ImageTests_timeoutMinutes
--- PASS: TestAccImageBuilderImage_workflows (827.23s)
=== CONT  TestAccImageBuilderComponent_supportedOsVersions
--- PASS: TestAccImageBuilderComponent_supportedOsVersions (13.37s)
=== CONT  TestAccImageBuilderImage_containerRecipeARN
--- PASS: TestAccImageBuilderImage_tags (897.99s)
=== CONT  TestAccImageBuilderInfrastructureConfiguration_description
--- PASS: TestAccImageBuilderInfrastructureConfiguration_description (57.79s)
=== CONT  TestAccImageBuilderImage_imageScanningConfiguration
    image_test.go:278: Amazon Inspector not available: operation error Inspector2: ListDelegatedAdminAccounts, https response error StatusCode: 403, RequestID: 84e629aa-78dd-4bb7-8989-f0113fb2d82c, AccessDeniedException: Invoking account is not organization administrator account
--- SKIP: TestAccImageBuilderImage_imageScanningConfiguration (0.34s)
=== CONT  TestAccImageBuilderImagePipeline_Schedule_timezone
--- PASS: TestAccImageBuilderImagePipeline_Schedule_timezone (35.11s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_encrypted
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMappingEBS_encrypted (15.30s)
=== CONT  TestAccImageBuilderImageRecipe_BlockDeviceMapping_deviceName
--- PASS: TestAccImageBuilderImageRecipe_BlockDeviceMapping_deviceName (15.04s)
=== CONT  TestAccImageBuilderImage_ImageTests_imageTestsEnabled
--- PASS: TestAccImageBuilderImage_containerRecipeARN (528.68s)
=== CONT  TestAccImageBuilderComponent_kmsKeyID
--- PASS: TestAccImageBuilderComponent_kmsKeyID (15.96s)
--- PASS: TestAccImageBuilderImage_ImageTests_timeoutMinutes (878.60s)
--- PASS: TestAccImageBuilderImage_ImageTests_imageTestsEnabled (540.23s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	4028.467s
FAIL
make: *** [testacc] Error 1

Blocked by aws/aws-sdk-go-v2#2734.

@ewbankkit
Merge branch 'main' into HEAD
a18d5ca 
# Conflicts:
#	go.mod
#	go.sum
#	internal/conns/awsclient_gen.go
#	internal/generate/namevaluesfilters/v1/main.go
#	internal/generate/namevaluesfilters/v2/main.go
#	internal/namevaluesfilters/v1/service_filters_gen.go
#	internal/namevaluesfilters/v2/service_filters_gen.go
#	names/names.go
@ewbankkit
No more AWS SDK for Go v1 'namevaluesfilters'.
30d5697
@ewbankkit ewbankkit mentioned this pull request Sep 12, 2024
Merged
@ewbankkit
Merge branch 'main' into HEAD
75da52f 
# Conflicts:
#	go.mod
#	go.sum
#	internal/service/imagebuilder/generate.go
@ewbankkit
Fix semgrep 'ci.semgrep.framework.model-tag-types'.
4aad53c
@ewbankkit
Merge branch 'main' into HEAD
b958507 
# Conflicts:
#	go.mod
#	go.sum
#	names/data/names_data.hcl
@ewbankkit
Fix semgrep 'ci.semgrep.framework.flex-type-from-framework'.
c9b6615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorge-Rodriguez Jorge-Rodriguez Jorge-Rodriguez left review comments

@Kaniee Kaniee Kaniee left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-resource Introduces a new resource. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] EC2 Image Builder Service [New Resource]: aws_imagebuilder_lifecycle_policy
6 participants
@bschaatsbergen @ewbankkit @Jorge-Rodriguez @Kaniee @justinretzolk @DanielRieske