-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_elasticache_parameter_group: reset ID if deleted manually #32669
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccElastiCacheParameterGroup_' PKG=elasticache ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elasticache/... -v -count 1 -parallel 2 -run=TestAccElastiCacheParameterGroup_ -timeout 180m
=== RUN TestAccElastiCacheParameterGroup_basic
=== PAUSE TestAccElastiCacheParameterGroup_basic
=== RUN TestAccElastiCacheParameterGroup_disappears
=== PAUSE TestAccElastiCacheParameterGroup_disappears
=== RUN TestAccElastiCacheParameterGroup_addParameter
=== PAUSE TestAccElastiCacheParameterGroup_addParameter
=== RUN TestAccElastiCacheParameterGroup_removeAllParameters
=== PAUSE TestAccElastiCacheParameterGroup_removeAllParameters
=== RUN TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_allParameters
=== PAUSE TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_allParameters
=== RUN TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_remainingParameters
=== PAUSE TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_remainingParameters
=== RUN TestAccElastiCacheParameterGroup_switchReservedMemoryParameter
=== PAUSE TestAccElastiCacheParameterGroup_switchReservedMemoryParameter
=== RUN TestAccElastiCacheParameterGroup_updateReservedMemoryParameter
=== PAUSE TestAccElastiCacheParameterGroup_updateReservedMemoryParameter
=== RUN TestAccElastiCacheParameterGroup_uppercaseName
=== PAUSE TestAccElastiCacheParameterGroup_uppercaseName
=== RUN TestAccElastiCacheParameterGroup_description
=== PAUSE TestAccElastiCacheParameterGroup_description
=== RUN TestAccElastiCacheParameterGroup_tags
=== PAUSE TestAccElastiCacheParameterGroup_tags
=== CONT TestAccElastiCacheParameterGroup_basic
=== CONT TestAccElastiCacheParameterGroup_switchReservedMemoryParameter
--- PASS: TestAccElastiCacheParameterGroup_basic (29.90s)
=== CONT TestAccElastiCacheParameterGroup_removeAllParameters
--- PASS: TestAccElastiCacheParameterGroup_switchReservedMemoryParameter (50.46s)
=== CONT TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_remainingParameters
--- PASS: TestAccElastiCacheParameterGroup_removeAllParameters (43.21s)
=== CONT TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_allParameters
--- PASS: TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_remainingParameters (46.75s)
=== CONT TestAccElastiCacheParameterGroup_addParameter
--- PASS: TestAccElastiCacheParameterGroup_RemoveReservedMemoryParameter_allParameters (45.52s)
=== CONT TestAccElastiCacheParameterGroup_disappears
--- PASS: TestAccElastiCacheParameterGroup_disappears (19.90s)
=== CONT TestAccElastiCacheParameterGroup_description
--- PASS: TestAccElastiCacheParameterGroup_addParameter (44.32s)
=== CONT TestAccElastiCacheParameterGroup_tags
--- PASS: TestAccElastiCacheParameterGroup_description (25.69s)
=== CONT TestAccElastiCacheParameterGroup_uppercaseName
--- PASS: TestAccElastiCacheParameterGroup_uppercaseName (26.70s)
=== CONT TestAccElastiCacheParameterGroup_updateReservedMemoryParameter
--- PASS: TestAccElastiCacheParameterGroup_tags (63.77s)
--- PASS: TestAccElastiCacheParameterGroup_updateReservedMemoryParameter (43.74s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elasticache 239.845s
@tthompson-figma Thanks for the contribution 🎉 👏. |
@ewbankkit Thanks for running the tests and finishing up!! |
} | ||
|
||
return tfresource.AssertSinglePtrResult(output.CacheParameterGroups) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh TIL!
This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
If a parameter group in state is not found in AWS during resource read, reset the group's ID to force its recreation instead of failing immediately.
Relations
Closes #18338.
Closes #32244.
Output from Acceptance Testing
Running now, will post when complete!
% make testacc PKG=elasticache