-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(s3_object): add support of KMS alias #32124
Open
jeremychauvet
wants to merge
12
commits into
hashicorp:main
Choose a base branch
from
jeremychauvet:b-24921-add-support-of-kms-alias-for-s3-objects
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
enhancement(s3_object): add support of KMS alias #32124
jeremychauvet
wants to merge
12
commits into
hashicorp:main
from
jeremychauvet:b-24921-add-support-of-kms-alias-for-s3-objects
+98
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-for-s3-objects' into b-24921-add-support-of-kms-alias-for-s3-objects
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
Introduces or discusses updates to documentation.
service/s3
Issues and PRs that pertain to the s3 service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
size/M
Managed by automation to categorize the size of a PR.
needs-triage
Waiting for first response or review from a maintainer.
labels
Jun 21, 2023
…-for-s3-objects' into b-24921-add-support-of-kms-alias-for-s3-objects
justinretzolk
added
bug
Addresses a defect in current functionality.
and removed
needs-triage
Waiting for first response or review from a maintainer.
labels
Jun 21, 2023
MR ready for review 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Addresses a defect in current functionality.
documentation
Introduces or discusses updates to documentation.
service/s3
Issues and PRs that pertain to the s3 service.
size/M
Managed by automation to categorize the size of a PR.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support of KMS Key alias when uploading an object to an S3 bucket.
Relations
Closes #24921
References
https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html
Output from Acceptance Testing