Add sesv2 data sources for email identity and mail from attributes

[jchorl]

Description

Adds two data sources:

• aws_sesv2_email_identity
• aws_sesv2_email_identity_mail_from_attributes

Relations

Relates #26796

References

I mostly cargo-culted the other two data sources that were present

Output from Acceptance Testing

I first tested manually:

data "aws_sesv2_email_identity" "example" {
  email_identity = "example.com"
}

data "aws_sesv2_email_identity_mail_from_attributes" "example" {
  email_identity = data.aws_sesv2_email_identity.example.email_identity
}

output "tokens" {
  value = data.aws_sesv2_email_identity.example.dkim_signing_attributes[0].tokens
}

output "mail_from" {
  value = data.aws_sesv2_email_identity_mail_from_attributes.example.mail_from_domain
}

terraform refresh showed the values!

Then I did some automated testing:

root@ca07733e14b8:/work# make testacc TESTS=TestAccSESV2EmailIdentityDataSource_basic PKG=sesv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2EmailIdentityDataSource_basic'  -timeout 180m
=== RUN   TestAccSESV2EmailIdentityDataSource_basic
=== PAUSE TestAccSESV2EmailIdentityDataSource_basic
=== CONT  TestAccSESV2EmailIdentityDataSource_basic
--- PASS: TestAccSESV2EmailIdentityDataSource_basic (48.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      49.039s


root@ca07733e14b8:/work# make testacc TESTS=TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic PKG=sesv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic'  -timeout 180m
=== RUN   TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic
=== CONT  TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic
--- PASS: TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic (48.79s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      48.954s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

$ make testacc PKG=sesv2 TESTS=TestAccSESV2EmailIdentityDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2EmailIdentityDataSource_'  -timeout 180m
=== RUN   TestAccSESV2EmailIdentityDataSource_basic
=== PAUSE TestAccSESV2EmailIdentityDataSource_basic
=== CONT  TestAccSESV2EmailIdentityDataSource_basic
--- PASS: TestAccSESV2EmailIdentityDataSource_basic (17.86s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      21.028s

$ make testacc PKG=sesv2 TESTS=TestAccSESV2EmailIdentityMailFromAttributesDataSource_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2EmailIdentityMailFromAttributesDataSource_'  -timeout 180m
=== RUN   TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic
=== PAUSE TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic
=== CONT  TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic
--- PASS: TestAccSESV2EmailIdentityMailFromAttributesDataSource_basic (18.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      21.583s

[jar-b]

Thanks for your contribution, @jchorl! 👍

[github-actions]

This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[jchorl]

For my edification, why is this commit necessary? Do folks add diagnostics in non-error cases? Is this just setting up for a future where we may add diagnostics all throughout this function?

[jar-b]

The latter - future-proofing for cases where we might add non-error diagnostics. The newer Plugin-Framework uses this diagnostics pattern, so we try to make Plugin-SDK based resources look similar.

There are a bunch of legacy Plugin-SDK based resources that don't look this way, but when new stuff comes in its a simple enough change we usually switch over.

[jchorl]

I think this was my first aws tf contribution, so thanks a bunch for cleaning it up and driving it through.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.