Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: add tgw route table in aws_networkmanager_attachment_accepter ✨ #32023

Merged
merged 6 commits into from
Jun 16, 2023

Conversation

b-diggity
Copy link
Contributor

@b-diggity b-diggity commented Jun 15, 2023

Description

Adding the ability to accept Transit Gateway Route Table attachments in the aws_networkmanager_attachment_accepter resource. Currently, when trying to accept a Transit Gateway Route Table attachment, the following error is thrown:

Error: expected attachment_type to be one of [VPC SITE_TO_SITE_VPN CONNECT], got TRANSIT_GATEWAY_ROUTE_TABLE

Relations

Closes #26420 (note: I'm closing this issues since this appears to be the only remaining type not supported by the accepter)

References

https://docs.aws.amazon.com/networkmanager/latest/APIReference/API_ListAttachments.html#API_ListAttachments_RequestSyntax
https://github.com/aws/aws-sdk-go/blob/main/service/networkmanager/api.go#L23525

Output from Acceptance Testing

Note to admins/maintainers: I need help with testing this PR.

$ make testacc TESTS=TestAccXXX PKG=networkmanager

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/networkmanager Issues and PRs that pertain to the networkmanager service. size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jun 15, 2023
@b-diggity b-diggity changed the title feat: add tgw route table in aws_networkmanager_attachment_accepter ✨ [Enhancement]: add tgw route table in aws_networkmanager_attachment_accepter ✨ Jun 15, 2023
@b-diggity b-diggity marked this pull request as ready for review June 16, 2023 02:55
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 16, 2023
@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jun 16, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

 make testacc TESTARGS='-run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic' PKG=networkmanager ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 2  -run=TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic -timeout 180m
=== RUN   TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== PAUSE TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
=== CONT  TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic
--- PASS: TestAccNetworkManagerTransitGatewayRouteTableAttachment_basic (1517.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	1522.930s

@ewbankkit
Copy link
Contributor

@b-diggity Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4e5631f into hashicorp:main Jun 16, 2023
@github-actions github-actions bot added this to the v5.5.0 milestone Jun 16, 2023
@github-actions
Copy link

This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/networkmanager Issues and PRs that pertain to the networkmanager service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_networkmanager_attachment_accepter NOT accepting the other type of attachments.
2 participants