Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support provider defined functions #1636

Merged
merged 6 commits into from
Mar 26, 2024
Merged

feat: support provider defined functions #1636

merged 6 commits into from
Mar 26, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Feb 15, 2024 •
edited
Loading

Merge core functions with provider defined functions and suggest both

Resolves #1613

@ansgarm ansgarm force-pushed the poc-provider-functions branch from 12b33b1 to 34ea2bd Compare February 15, 2024 09:12
@ansgarm ansgarm mentioned this pull request Feb 21, 2024
Closed
11 tasks
@ansgarm ansgarm marked this pull request as ready for review February 23, 2024 12:05
@ansgarm ansgarm requested a review from a team as a code owner February 23, 2024 12:05
@ansgarm ansgarm force-pushed the poc-provider-functions branch from c0beab4 to 995905a Compare March 22, 2024 13:42
ansgarm
ansgarm commented Mar 22, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
ansgarm
ansgarm commented Mar 22, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@ansgarm ansgarm force-pushed the poc-provider-functions branch from 995905a to 38eed1e Compare March 22, 2024 13:49
@dbanck dbanck force-pushed the poc-provider-functions branch from 38eed1e to 6fa9036 Compare March 26, 2024 15:47
@dbanck dbanck force-pushed the poc-provider-functions branch from 6fa9036 to 20af20e Compare March 26, 2024 15:56
@dbanck dbanck merged commit 9acbaee into main Mar 26, 2024
21 checks passed
@dbanck dbanck deleted the poc-provider-functions branch March 26, 2024 16:06
@BrewTestBot BrewTestBot mentioned this pull request Apr 10, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace coreFunctions with the new functions merger
2 participants
@ansgarm @dbanck