Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(TFECO-8260) Add Heimdall metadata #142

Closed
wants to merge 2 commits into from
Closed

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Nov 21, 2024

This change adds the metadata for the internal Heimdall service to the repository

This change adds the metadata for the internal Heimdall service to the repository
@jpogran jpogran self-assigned this Nov 21, 2024
@jpogran jpogran marked this pull request as ready for review November 21, 2024 18:23
@jpogran jpogran requested review from a team as code owners November 21, 2024 18:23
category: library

summary:
owner: team-tf-editor-experience
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a compliance perspective, the Core team are currently considered the owners of this library. I don't mind having this be y'all, but then we should probably be consistent and have the compliance owners changed to you all as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it as Core then! @jpogran would you mind updating this field

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following the ticket, but will definitely cede to the registered owner!

# SPDX-License-Identifier: MPL-2.0

schema: 1.1
partition: tf-ecosystem
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deniseyu @xiehan The partition is loosely defined in the schema. Is there a better choice here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. I personally have been against implementing Heimdall cataloguing for open source repos, the only thing I've implemented it for are private repos tangentially related to TFC so I used "tfc" for those.

Is there a reason why we're doing this for these repos now?

@jpogran
Copy link
Contributor Author

jpogran commented Nov 25, 2024

Closing and will update ticket reflecting correct ownership of this repo

@jpogran jpogran closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants