Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Update readme #48

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

hngerebara
Copy link

@hngerebara hngerebara commented Nov 1, 2019

What does this PR do?

This updates the README to be in line with our new format.

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 1, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments on the Consul AWS PR, as just about all of them apply here!

move consul server and client deployments to core-concepts
modify features
@hngerebara
Copy link
Author

All done

Copy link
Collaborator

@robmorgan robmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 minor feedback.


To deploy Consul servers using this Module:
![Terraform Google Consul](https://raw.githubusercontent.com/hashicorp/terraform-google-consul/master/_docs/architecture.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Terraform Google Consul](https://raw.githubusercontent.com/hashicorp/terraform-google-consul/master/_docs/architecture.png)
![Terraform Google Consul](https://raw.githubusercontent.com/hashicorp/terraform-google-consul/master/_docs/architecture.png)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants