-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new section describing how to find module deprecation data using the API #811
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions on the wording. I think we should move this to this page, though, to start breaking the usage from the reference content: https://developer.hashicorp.com/terraform/cloud-docs/registry/manage-module-versions
website/docs/cloud-docs/api-docs/private-registry/manage-module-versions.mdx
Outdated
Show resolved
Hide resolved
website/docs/cloud-docs/api-docs/private-registry/manage-module-versions.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: trujillo-adam <[email protected]>
@trujillo-adam So, I disagree because of our current split in API v.s. non-API docs. The article you linked explains where to find deprecated data in the UI as part of the UI workflow of deprecating versions. However, if someone was looking for how to use the API to find deprecation data - this feels like where they would look because they are already presumably using the API to deprecate modules. Does that make sense? We could put it on the the usage page and link to that section from the API reference page - but that feels a little less ideal then just putting the information on the API page itself. However, I totally acknowledge this is just my two cents, so I don't feel super strongly and would be down to move it if you think that's better. 😅 |
Quick PR to add a section on how to use the Private Registry API to find details on a module's deprecation.