-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document unique pagination method used in Org Runs Index endpoint #770
base: main
Are you sure you want to change the base?
Document unique pagination method used in Org Runs Index endpoint #770
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"next-page": 2, | ||
"prev-page": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On line 554, there there is a "links" section. We could also reinforce the flexibility of the existing data by including the pagination links (not this example in particular but something similar)
This exists on workspace runs.. does it also exist on org runs?
For example:
"links": {
"self": "https://app.terraform.io/api/v2/workspaces/ws-SqohByt1nDRfQhzT/runs?filter%5Boperation%5D=plan_only&page%5Bnumber%5D=1&page%5Bsize%5D=20",
"first": "https://app.terraform.io/api/v2/workspaces/ws-SqohByt1nDRfQhzT/runs?filter%5Boperation%5D=plan_only&page%5Bnumber%5D=1&page%5Bsize%5D=20",
"prev": null,
"next": null,
"last": "https://app.terraform.io/api/v2/workspaces/ws-SqohByt1nDRfQhzT/runs?filter%5Boperation%5D=plan_only&page%5Bnumber%5D=1&page%5Bsize%5D=20"
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hadn't considered including this metadata portion from the original pagination method. Currently the related PR for the org runs endpoint pagination update doesn't have these links. I'm wondering if it's worth adding them now, though I suppose it wouldn't be a breaking change if the new pagination method was later updated if there was a found need for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the associated altas PR to include pagination links, as well as documented them here: c8aefb1
Additionally added pagination documentation for the workspace run list endpoint to better highlight the differences.
…ce runs list docs to include pagination metadata
What
Documented the unique pagination used in the
GET /organizations/:organization_name/runs
endpoint.Related PR: https://github.com/hashicorp/atlas/pull/21346
Why
To surface to users the details of the atypical pagination metadata included in the response.
Merge Checklist
If items do not apply to your changes, add (N/A) and mark them as complete.
Pull Request
Content
website/redirects.js
for moved, renamed, or deleted pages. N/AReviews