Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add web presence ability to approve PRs to website files #3788

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

judithpatudith
Copy link
Contributor

I'm trying to standardize who can approve PRs to docs across all our code repos. Please let me know if you have any feedback!

Related issue

Fixes #

Description

In plain English, describe your approach to addressing the issue linked above. For example, if you made a particular design decision, let us know why you chose this path instead of another solution.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@judithpatudith judithpatudith requested a review from a team as a code owner December 13, 2024 21:47
@judithpatudith judithpatudith requested review from mutahhir and ansgarm and removed request for a team December 13, 2024 21:47
@judithpatudith judithpatudith changed the title Add web presence ability to approve PRs to website files chore: Add web presence ability to approve PRs to website files Dec 17, 2024
@DanielMSchmidt DanielMSchmidt added this pull request to the merge queue Dec 20, 2024
@DanielMSchmidt DanielMSchmidt removed this pull request from the merge queue due to a manual request Dec 20, 2024
@DanielMSchmidt DanielMSchmidt merged commit 54d5252 into main Dec 20, 2024
846 of 848 checks passed
@DanielMSchmidt DanielMSchmidt deleted the judith/edu-web-codeowners branch December 20, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants