Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style and SEO updates #3775

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Style and SEO updates #3775

wants to merge 2 commits into from

Conversation

robin-norwood
Copy link
Collaborator

Update titles, descriptions, and page headers to comply with style guide and optimize for SEO

Related issue

IPE-982

Description

This updates the CDKTF documentation per our style guide and SEO optimization guidelines.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left suggestions for ensuring consistency across title and h1s, but feel free to ignore anything that doesn't feel good!

@@ -1,9 +1,11 @@
---
page_title: C# API resource reference overview
description: Learn about the API resources available in the Terraform CDK library for C#.
page_title: CDKTF C# API resource reference overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
page_title: CDKTF C# API resource reference overview
page_title: CDKTF C# API resource reference

description: Learn about the API resources available in the Terraform CDK library for golang.
page_title: Go TypeScript API reference overview
description: >-
Use the Terraform CDK library for Go to define your CDK for Terraform application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can omit "application"?

Suggested change
Use the Terraform CDK library for Go to define your CDK for Terraform application.
Use the Terraform CDK library for Go to define your CDK for Terraform.

@@ -1,9 +1,10 @@
---
page_title: Go API resource reference overview
description: Learn about the API resources available in the Terraform CDK library for golang.
page_title: Go TypeScript API reference overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
page_title: Go TypeScript API reference overview
page_title: Go TypeScript API overview

---

# Go API resource reference overview
# CDKTF Go API reference overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can stick with just "overview" here:

Suggested change
# CDKTF Go API reference overview
# CDKTF Go API overview

@@ -1,10 +1,12 @@
---
page_title: API Reference - CDKTF Core Library
page_title: CDKTF core library API Reference
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
page_title: CDKTF core library API Reference
page_title: CDKTF core library API reference

---

# Synthesization Performance
# Synthesization performance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Synthesization performance
# Optimize performance for CDKTF

@@ -1,9 +1,11 @@
---
page_title: Performance - CDK for Terraform
description: The faster you can synthesize your CDKTF code, the faster you can deploy it. Learn how to optimize your CDK for Terraform performance.
page_title: Performance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
page_title: Performance
page_title: Optimize performance for CDKTF

@@ -1,11 +1,11 @@
---
page_title: Project Setup - CDK for Terraform
page_title: Project setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
page_title: Project setup
page_title: Set up a new CDK for Terraform new project

@@ -1,11 +1,11 @@
---
page_title: Remote Templates - CDK for Terraform
page_title: Remote templates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
page_title: Remote templates
page_title: Remote templates with CDK for Terraform

page_title: Construct Design | CDK for Terraform
description: |-
Write highly configurable construct classes that provide guidance for a wide range of use cases.
page_title: Design constructs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
page_title: Design constructs
page_title: Design CDKTF constructs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants