Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): expose conditional #3264

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

BJMg
Copy link

@BJMg BJMg commented Nov 13, 2023

Related issue

Fixes #2818

Description

Missing conditional expression in Java and other non-typescript languages. This PR attempts to expose it to JSII.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@BJMg BJMg requested a review from a team as a code owner November 13, 2023 12:24
@BJMg BJMg requested review from mutahhir and DanielMSchmidt and removed request for a team November 13, 2023 12:24
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 13, 2023

CLA assistant check
All committers have signed the CLA.

@BJMg
Copy link
Author

BJMg commented Nov 13, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

This is False Positive I have signed the CLA even before I created PR. And it is signed when I open the link. Recheck doesn't help.

@BJMg BJMg changed the title fix(provider-generator): expose conditional fix(lib): expose conditional Nov 14, 2023
@xiehan xiehan changed the title fix(lib): expose conditional fix(lib): expose conditional Nov 15, 2023
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks for the help 🙌

@xiehan
Copy link
Member

xiehan commented Nov 29, 2023

@BJMg We'd love to merge your PR, but we can't do so until the CLA has been confirmed to be signed!

If the CLA bot is saying the CLA hasn't been signed yet, it's most likely because the email address you signed it with (the default email address associated with your GitHub account) doesn't match the email address on the commit (in the git log). The email address on the commit is [email protected]. You'll need to either re-sign the CLA using that email address, or do some sort of git commit config --global user.email "your email" and git commit --amend on the commit to use the email address that you signed the CLA with.

@BJMg
Copy link
Author

BJMg commented Nov 29, 2023

@BJMg We'd love to merge your PR, but we can't do so until the CLA has been confirmed to be signed!

If the CLA bot is saying the CLA hasn't been signed yet, it's most likely because the email address you signed it with (the default email address associated with your GitHub account) doesn't match the email address on the commit (in the git log). The email address on the commit is [email protected]. You'll need to either re-sign the CLA using that email address, or do some sort of git commit config --global user.email "your email" and git commit --amend on the commit to use the email address that you signed the CLA with.

Thanks for clarification. I haven't realized it takes email from my commits. Everything should be fine now.

@DanielMSchmidt DanielMSchmidt merged commit d1f0b62 into hashicorp:main Nov 29, 2023
232 checks passed
@BJMg BJMg deleted the expose-conditional branch November 29, 2023 16:53
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose conditional() and other expression helpers through JSII
6 participants