-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lib): expose conditional
#3264
Conversation
This is False Positive I have signed the CLA even before I created PR. And it is signed when I open the link. Recheck doesn't help. |
expose
conditionalexpose
conditional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks for the help 🙌
@BJMg We'd love to merge your PR, but we can't do so until the CLA has been confirmed to be signed! If the CLA bot is saying the CLA hasn't been signed yet, it's most likely because the email address you signed it with (the default email address associated with your GitHub account) doesn't match the email address on the commit (in the git log). The email address on the commit is [email protected]. You'll need to either re-sign the CLA using that email address, or do some sort of |
Thanks for clarification. I haven't realized it takes email from my commits. Everything should be fine now. |
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Related issue
Fixes #2818
Description
Missing conditional expression in Java and other non-typescript languages. This PR attempts to expose it to JSII.
Checklist