fix(provider-generator): java akamai provider generation #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maed223
requested review from
ansgarm and
DanielMSchmidt
and removed request for
a team
DanielMSchmidt
requested changes
Oct 12, 2023
Signed-off-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
Maed223
force-pushed
the
akamai-provider-java-fix
branch
from
d3f0ae0 to
936a67e
Compare
DanielMSchmidt
approved these changes
Oct 16, 2023
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #3115
Description
Generation of Akamai provider fails to compile in Java since the the software field on the DNS resource config is confused with the JSII Java runtime package by the compiler.
Fix
Add the attribute name
softwareto our list of escaped attributes.Other Notes
Added the example
java/akamai-gradleto demonstrate that the fix works. Guessing it isn't worth keeping around so planning on removing it before merging.