fix: lower cache usage by reusing more of the yarn caches #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
requested review from
mutahhir and
Maed223
and removed request for
a team
ansgarm
force-pushed
the
lower-cache-usage
branch
from
38d58b2 to
e13b3ac
Compare
DanielMSchmidt
approved these changes
Oct 13, 2023
ansgarm
force-pushed
the
lower-cache-usage
branch
from
e13b3ac to
f18e977
Compare
DanielMSchmidt
force-pushed
the
lower-cache-usage
branch
from
f18e977 to
b077535
Compare
mutahhir
approved these changes
Nov 1, 2023
ansgarm
commented
Nov 6, 2023
There was a problem hiding this comment.
❌ (Can't request changes, as it's my PR 🙄)
The rebase actually removed some intended part, as can be seen in this old commit of mine: f18e977#diff-82454b2fc887e9985b9348b8f3bca03d2f839645a4c3ba1f3f850014d7da5c8bR118
Co-authored-by: Ansgar Mertens <[email protected]>
Co-authored-by: Ansgar Mertens <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github showed ~500MB per yarn cache, so let's not use one distinct cache per integration test or unit test since that definitely causes evictions at 10GB total maximum for caches 😅