fix: iterator examples #2456
Merged
fix: iterator examples #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutahhir
requested review from
a team,
mgarrell777 and
robin-norwood
as code owners
mutahhir
requested review from
DanielMSchmidt and
Maed223
and removed request for
a team
DanielMSchmidt
requested changes
Jan 4, 2023
DanielMSchmidt
approved these changes
Jan 4, 2023
examples/java/gradle-shared-module/gradle/wrapper/gradle-wrapper.properties
Show resolved
Hide resolved
mutahhir
force-pushed
the
fix/iterator-examples
branch
from
94c63bf to
9d5f561
Compare
mutahhir
force-pushed
the
fix/iterator-examples
branch
from
9d5f561 to
1fe2b11
Compare
mutahhir
force-pushed
the
fix/iterator-examples
branch
from
1fe2b11 to
a216fd4
Compare
|
This is failing on CSharp because of: aws/jsii#3870. we're currently on 1.71.0, while the fix is in 1.72.0. |
|
@mutahhir I think this needs a rebase :) |
mutahhir
force-pushed
the
fix/iterator-examples
branch
from
4b0f14a to
7bb0902
Compare
mutahhir
force-pushed
the
fix/iterator-examples
branch
from
7bb0902 to
f1c8516
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2452
Terraform only supports a set of strings, and maps with the
for_eachmeta-argument.The way for CDKTF to support complex list iterators would be to implement a kind of for expression when synthesising the iterator with
for_each, however that isn't currently supported.For now, this PR updates the example code to use maps instead of a complex list, until we implement the above.