Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to also import OVF templates to the Content Library #9755

Merged
merged 2 commits into from
Aug 19, 2020

Conversation

sylviamoss
Copy link
Contributor

@sylviamoss sylviamoss commented Aug 12, 2020

This updates the govmomi version to make use of the new function responsible for cloning the VM into the Content Library as an OVF template.
With the OVF template is possible to update existing library items and to use the VM name as the library item name.

Closes #9711

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #9755 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
builder/vsphere/clone/config.go 67.56% <ø> (ø)
...r/vsphere/common/step_import_to_content_library.go 0.00% <0.00%> (ø)
builder/vsphere/driver/library.go 0.00% <0.00%> (ø)
builder/vsphere/driver/vm.go 0.00% <0.00%> (ø)
packer/plugin/client.go 79.91% <0.00%> (-0.45%) ⬇️
builder/azure/dtl/tempname.go 75.00% <0.00%> (+6.25%) ⬆️

Copy link
Contributor

@SwampDragons SwampDragons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! If users validate that it works, then merge!

@sylviamoss sylviamoss changed the title Update existing library item with new template [WIP] Update existing library item with new template Aug 14, 2020
builder/vsphere/common/step_import_to_content_library.go Outdated Show resolved Hide resolved
builder/vsphere/driver/library.go Show resolved Hide resolved
@sylviamoss sylviamoss changed the title [WIP] Update existing library item with new template [WIP] Add option to also import OVF templates to the Content Library Aug 18, 2020
@sylviamoss sylviamoss changed the title [WIP] Add option to also import OVF templates to the Content Library Add option to also import OVF templates to the Content Library Aug 18, 2020
Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sylviamoss sylviamoss merged commit a1524bf into master Aug 19, 2020
@sylviamoss sylviamoss deleted the implement_9711 branch August 19, 2020 11:21
@SwampDragons SwampDragons added this to the 1.6.2 milestone Aug 19, 2020
@ghost
Copy link

ghost commented Oct 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to overwrite/update vSphere templates in Content Libraries
3 participants