[WIP] file: use excludes list to excl files when uploading a directory #12280
Conversation
Glyphack
force-pushed
the
file-provision-excludes
branch
from
961928b to
33fc558
Compare
| @@ -227,7 +232,7 @@ func (p *Provisioner) ProvisionUpload(ui packersdk.Ui, comm packersdk.Communicat | |||
|
|
|||
| // If we're uploading a directory, short circuit and do that | |||
| if info.IsDir() { | |||
| if err = comm.UploadDir(dst, src, nil); err != nil { | |||
| if err = comm.UploadDir(dst, src, p.config.Excludes); err != nil { | |||
There was a problem hiding this comment.
This change is needed in order to path in the list of files to exclude. But the actually implementation for supporting the excludes would need to be made in the Packer SDK communicator, which this line is calling out to. At this present time the exclude argument is ignored.
For the excludes we will need to provide guidance on the allowed paths and/or globs that can be passed into exclude, which I think the file provisioner could take on the work of expanding.
There was a problem hiding this comment.
Thank you for noticing this. I already started a PR on packer-sdk to address this. I also left a comment there about how the pattern matching should be. Could you also take a look?
|
Hey @nywilken I'm absolutely interested to continue this. Don't need to apologize I totally understand you 😃 . As you pointed out this change requires this packer-sdk PR to be merged. Do you think it's better to first merge that one and then complete the explanation for the exclude config based on the implementation in this PR? Let me know what you think and I'm ready to apply changes. |
|
@Glyphack thanks for updating the open PRs around this change. I got a little caught up with other priorities this week. I will follow up next week with feedback. Quickly looking at the SDK changes I would expect the same changes to exist for the WinRM communicator. But will have more details once I dive into the PR. Thanks again for this work and all the other contributions. They are much appreciated. |
|
I looked into adding this change for winRM. winrmcp project is used to copy the folder in this communicator, this dependency does not support excluding files, and it's not actively maintained. I'm thinking one solution would be to not use the copy function and use write function to rewrite the walking over the directory part. Another way would be to remove this dependency. I'm not sure which one is better right now. What are your suggestions? |
nywilken
added
stage/waiting-on-upstream
|
Hi @Glyphack sorry, just sorry. We haven't had a chance to prioritize this change, and it doesn't help with the state of winrmcp at the moment. We are discussing this internally to see where we go from here with WinRM and testing things. You are welcome to keep this PR open or can close until we have a plan forward. |
|
Hello @nywilken don't be sorry 😃, I understand that there are lots of issues, PRs, and beside that internal stuff so would not mind a late response. I would still like to work on it whenever you have chosen the solution. |
|
Thank you @Glyphack - I appreciate your understanding and patience with these changes. I'll keep the PR open and ping you when we are ready to discuss next steps. Cheers! |
Adds
excludesconfiguration for file provisioner to ignore paths from a directory while uploading.The implementation for excluding files during upload are in this PR
I will update the documents once the implementation details are agreed upon.
Question
I initially wanted to implement this feature as described here, and realized the UploadDir signature accepts an exclude arg.
Now my question is should this be implemented in this project or in the packer-sdk, here and here?
Resolves: #9671