[renderer] Fix variable handling in output templates (#453)

* Add test for bug; add outputs to fixtures with deps
* Get a PackTemplateContext from renderer's parsedVariables

fixtures/v2/test_registry/packs/deps_test_1/outputs.tpl

@@ -0,0 +1,7 @@
+{
+  "job_name": [[ var "job_name" . | quote ]],
+  "child1.job_name": [[ var "job_name" .child1 | quote ]],
+  "child1.gc.job_name": [[ var "job_name" .child1.gc | quote ]],
+  "child2.job_name": [[ var "job_name" .child2 | quote ]],
+  "child2.gc.job_name": [[ var "job_name" .child2.gc | quote ]]
+}

fixtures/v2/test_registry/packs/my_alias_test/outputs.tpl

@@ -0,0 +1 @@
+[[var "job_name" .]],[[var "job_name" .child1]],[[var "job_name" .child2]]

internal/cli/cli_test.go

@@ -550,6 +550,40 @@ func TestCLI_PackRender_SetDepVarWithFlag(t *testing.T) {
 	must.SliceContainsAll(t, expected, elems)
 }
 
+func TestCLI_PackRender_VarsInOutputTemplate(t *testing.T) {
+	t.Parallel()
+	// This test has to do some extra shenanigans because dependent pack template
+	// output is not guaranteed to be ordered. This requires that the test handle
+	// either order.
+	expected := []string{
+		"deps_test/child1/child1.nomad=override",
+		"deps_test/child2/child2.nomad=child2",
+		"deps_test/deps_test.nomad=deps_test",
+		"outputs.tpl=deps_test,override,child2",
+	}
+
+	result := runPackCmd(t, []string{
+		"render",
+		"--no-format=true",
+		"--var", "child1.job_name=override",
+		"--render-output-template=true",
+		getTestPackPath(t, "my_alias_test"),
+	})
+
+	must.Eq(t, result.cmdErr.String(), "", must.Sprintf("cmdErr should be empty, but was %q", result.cmdErr.String()))
+	must.Eq(t, 0, result.exitCode, must.Sprintf("incorrect exit code.\ncmdOut:\n%v\ns", result.cmdOut.String()))
+	must.StrNotContains(t, result.cmdOut.String(), "Error")
+
+	// Performing a little clever string manipulation on the render output to
+	// prepare it for splitting into a slice of string enables us to use
+	// require.ElementsMatch to validate goodness.
+	outStr := strings.TrimSpace(result.cmdOut.String())
+	outStr = strings.ReplaceAll(outStr, ":\n\n", "=")
+	elems := strings.Split(outStr, "\n")
+
+	must.SliceContainsAll(t, expected, elems, must.Sprintf("unexpected returned value.\nexpected: %v\nelems: %v\nstdout:\n%v\n", expected, elems, result.cmdOut.String()))
+}
+
 func TestCLI_CLIFlag_Namespace(t *testing.T) {
 	testCases := []struct {
 		desc   string

internal/pkg/renderer/renderer.go

@@ -182,8 +182,9 @@ func (r *Renderer) RenderOutput() (string, error) {
 		return "", err
 	}
 
+	ptc, _ := r.pv.ToPackTemplateContext(r.pack)
 	var buf strings.Builder
-	if err := r.tpl.ExecuteTemplate(&buf, r.pack.OutputTemplateFile.Name, r.pv); err != nil {
+	if err := r.tpl.ExecuteTemplate(&buf, r.pack.OutputTemplateFile.Name, ptc); err != nil {
 		return "", fmt.Errorf("failed to render %s: %v", r.pack.OutputTemplateFile.Name, err)
 	}