Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for always showing gzip diff #20

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jtadmor
Copy link

@jtadmor jtadmor commented Mar 21, 2022

Hi! Awesome library. One thing that would help us - while we have a budget set, seeing the raw size of the gzip diff is almost always wanted, whereas the current setup hides it if the budget is set.

I just added an option for allowing this.

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 21, 2022

CLA assistant check
All committers have signed the CLA.

@lourd
Copy link

lourd commented Oct 19, 2022

This looks awesome @jtadmor! @brkalow, could you review this please? My team would also really appreciate this feature. I believe it would also resolve #6 that you filed?

@jzxhuang
Copy link
Contributor

@brkalow @dstaley at a glance it looks like this would work still, any chance it could be merged? showing the raw size diff would be much appreciated, it's definitely more intuitive to me than the % difference!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants