Add tests for new product support and lambda handling

Testing the lambda event processing in a bit messy since it's effectively an end-to-end test and requires mocking a few different endpoints (GH raw, GH API, and Releases). But I figure it'd probably be a good idea to validate our event processing since errors there are hidden in cloudwatch.
hashicorp · Mar 22, 2023 · 9d21868 · 9d21868
1 parent c1f45c5
commit 9d21868
Showing 1 changed file with 162 additions and 0 deletions.
diff --git a/util/lambda_trigger/lambda_trigger_test.go b/util/lambda_trigger/lambda_trigger_test.go
@@ -2,7 +2,9 @@ package main
 
 import (
 	"testing"
+	"time"
 
+	"github.com/aws/aws-lambda-go/events"
 	"github.com/h2non/gock"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -95,3 +97,163 @@ func TestENTGetLatestVersion(t *testing.T) {
 	require.NoError(t, err)
 	assert.Equal(t, test_ent_version_formula, *gotLatest)
 }
+
+func TestNewProduct(t *testing.T) {
+	defer gock.Off()
+	gock.New("https://raw.githubusercontent.com").
+		Get("/hashicorp/homebrew-tap/master/Formula/a-new-product.rb").
+		Reply(404)
+	gock.New("https://raw.githubusercontent.com").
+		Get("/hashicorp/homebrew-tap/master/Cask/a-new-product.rb").
+		Reply(404)
+
+	_, err := getFormulaVersion("a-new-product")
+	require.Error(t, err, errBrewVersionNotFound)
+
+	_, err = getCaskVersion("a-new-product")
+	require.Error(t, err, errBrewVersionNotFound)
+}
+
+func TestGitHubTrigger(t *testing.T) {
+	defer gock.Off()
+
+	// Validate the POST payload contains the minimum subset we expect
+	triggerPayload := map[string]any{
+		"event_type": "version-updated",
+		"client_payload": map[string]any{
+			"name":    "a-new-app",
+			"version": "0.1.0",
+			"cask":    "false",
+		},
+	}
+
+	gock.New("https://api.github.com").
+		Post("/repos/hashicorp/homebrew-tap/dispatches").
+		HeaderPresent("Authorization").
+		MatchType("json").
+		JSON(triggerPayload).
+		Reply(204).
+		BodyString("")
+
+	err := triggerGithubWorkflow(&ReleaseEvent{
+		Product: "a-new-app",
+		Version: "0.1.0",
+		Cask:    false,
+	})
+	assert.NoError(t, err)
+
+	gock.New("https://api.github.com").
+		Post("/repos/hashicorp/not-homebrew-tap/dispatches").
+		HeaderPresent("Authorization").
+		MatchType("json").
+		JSON(triggerPayload).
+		Reply(403)
+
+	err = triggerGithubWorkflow(&ReleaseEvent{
+		Product: "a-new-app",
+		Version: "0.1.0",
+		Cask:    false,
+	})
+	assert.Error(t, err)
+}
+
+func TestHandleLambdaEventUnuspportedProduct(t *testing.T) {
+	unsupportedRecord := events.SNSEventRecord{
+		EventSource: "test",
+		SNS: events.SNSEntity{
+			Timestamp: time.Now(),
+			Message:   `{"product": "an-unsupported-app"}`,
+			MessageID: "deadbeef",
+		},
+	}
+	err := HandleLambdaEvent(events.SNSEvent{
+		Records: []events.SNSEventRecord{unsupportedRecord},
+	})
+	assert.NoError(t, err)
+}
+
+func TestHandleLambdaEventExistingProduct(t *testing.T) {
+	defer gock.Off()
+	gock.New("https://api.releases.hashicorp.com").
+		Get("/v1/releases/boundary-desktop/latest").
+		MatchParam("license_class", "oss").
+		Reply(200).
+		File("testdata/releases.com_boundary-desktop.json")
+	gock.New("https://raw.githubusercontent.com").
+		Get("/hashicorp/homebrew-tap/master/Casks/hashicorp-boundary-desktop.rb").
+		Reply(200).
+		File("testdata/github.com_cask_boundary-desktop.rb")
+	oldSupportedRecord := events.SNSEventRecord{
+		EventSource: "test",
+		SNS: events.SNSEntity{
+			Timestamp: time.Now(),
+			Message:   `{"product": "boundary-desktop"}`,
+			MessageID: "deadbeef",
+		},
+	}
+	err := HandleLambdaEvent(events.SNSEvent{
+		Records: []events.SNSEventRecord{oldSupportedRecord},
+	})
+	assert.Error(t, err, "formula/cask is already latest version")
+}
+
+func TestHandleLambdaEventNewProduct(t *testing.T) {
+	defer gock.Off()
+	// To test "new" since our product list is hard-coded we re-use an existing product but return a 404 instead
+	gock.New("https://raw.githubusercontent.com").
+		Get("/hashicorp/homebrew-tap/master/Casks/hashicorp-boundary-desktop.rb").
+		Reply(404)
+	gock.New("https://api.releases.hashicorp.com").
+		Get("/v1/releases/boundary-desktop/latest").
+		MatchParam("license_class", "oss").
+		Reply(200).
+		File("testdata/releases.com_boundary-desktop.json")
+	gock.New("https://api.github.com").
+		Post("/repos/hashicorp/homebrew-tap/dispatches").
+		HeaderPresent("Authorization").
+		MatchType("json").
+		Reply(204).
+		BodyString("")
+
+	newSupportedRecord := events.SNSEventRecord{
+		EventSource: "test",
+		SNS: events.SNSEntity{
+			Timestamp: time.Now(),
+			Message:   `{"product": "boundary-desktop"}`,
+			MessageID: "deadbeef",
+		},
+	}
+	err := HandleLambdaEvent(events.SNSEvent{
+		Records: []events.SNSEventRecord{newSupportedRecord},
+	})
+	assert.NoError(t, err)
+
+	// And we'll also test the Formula bits too, because why not.
+	// To test "new" since our product list is hard-coded we re-use an existing product but return a 404 instead
+	gock.New("https://raw.githubusercontent.com").
+		Get("/hashicorp/homebrew-tap/master/Formula/nomad.rb").
+		Reply(404)
+	gock.New("https://api.releases.hashicorp.com").
+		Get("/v1/releases/nomad/latest").
+		MatchParam("license_class", "oss").
+		Reply(200).
+		File("testdata/releases.com_nomad-oss.json")
+	gock.New("https://api.github.com").
+		Post("/repos/hashicorp/homebrew-tap/dispatches").
+		HeaderPresent("Authorization").
+		MatchType("json").
+		Reply(204).
+		BodyString("")
+	newSupportedFormulaRecord := events.SNSEventRecord{
+		EventSource: "test",
+		SNS: events.SNSEntity{
+			Timestamp: time.Now(),
+			Message:   `{"product": "nomad"}`,
+			MessageID: "deadbeef",
+		},
+	}
+	err = HandleLambdaEvent(events.SNSEvent{
+		Records: []events.SNSEventRecord{newSupportedFormulaRecord},
+	})
+	assert.NoError(t, err)
+}