decoder: Decouple validators & make them pluggable via PathContext #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-decouple-validators
branch
2 times, most recently
from
4c23702
to
bd10827
Compare
dbanck
reviewed
Sep 19, 2023
radeksimko
force-pushed
the
f-decouple-validators
branch
from
bd10827
to
b66d8c6
Compare
This was referenced Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decoupling is aiming mainly to unblock support for multiple language IDs (schemas) with different needs for validation as shown in hashicorp/terraform-ls#1413
It's expected to be useful outside of Terraform LS though in the future.