Introduce decoder.ValidateFile
#310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
Aug 31, 2023
decoder/validate.go
Outdated
|
|
||
| body, ok := f.Body.(*hclsyntax.Body) | ||
| if !ok { | ||
| // TODO! error |
There was a problem hiding this comment.
👀
I think we should mimic what we do in other similar methods already - i.e. return error to say that JSON isn't supported.
decoder/validate.go
Outdated
| @@ -48,6 +48,28 @@ func (d *PathDecoder) Validate(ctx context.Context) (lang.DiagnosticsMap, error) | |||
| return diags, nil | |||
| } | |||
|
|
|||
| // ValidateFile returns a list of Diagnostics for a specific file | |||
There was a problem hiding this comment.
Suggested change
| // ValidateFile returns a list of Diagnostics for a specific file | |
| // ValidateFile validates given file and returns a list of Diagnostics for that file |
Nitpick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method to the decoder for validating a single file