Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder: Enable validators to deal with unknown schema #301

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

radeksimko
Copy link
Member

Depends on #299

Closes #291


Comments should be self-explanatory and the implementation works exactly as described/desired in #291 - i.e.

If merging is successful we can continue as normal
If not, we have to skip some validations, like required attribute/block detection
If we encounter a attribute/block that still exists in the schema (must be part of the core schema then), we can return to normal validation for that one

This is all driven by a flag which we provide through the context.

@radeksimko radeksimko added the enhancement New feature or request label Aug 10, 2023
@radeksimko radeksimko requested a review from a team as a code owner August 10, 2023 08:37
@radeksimko radeksimko self-assigned this Aug 10, 2023
Base automatically changed from validate_support_schema_ext to main August 10, 2023 12:39
@radeksimko radeksimko force-pushed the f-validation-missing-dep-schemas branch from ce29849 to 1c9dc1e Compare August 10, 2023 12:41
@radeksimko radeksimko merged commit 5753e81 into main Aug 10, 2023
4 checks passed
@radeksimko radeksimko deleted the f-validation-missing-dep-schemas branch August 10, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decoder: validateBody should ignore missing provider schemas
2 participants