Group 4: Banner and Image audit on the website #2907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this audit I fixed the following component pages: - Button - Code-editor - Flyout - Form / File-input - Form / Masked-input - Modal - Page-header - Flex - Grid --- All other pages (x) total are okay with no changes needed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
majedelass
reviewed
May 28, 2025
website/docs/components/code-editor/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
website/docs/components/code-editor/partials/guidelines/guidelines.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Majed <[email protected]>
|
@andgen404 Should I be checking banner placement on the "Code" tab as well as the "Guidelines" tab? For example, this one from the MaskedInput Code tab: |
Yes, both tabs. If a banner placement feels out of place, please note it. Thank you! |
majedelass
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group 3: @majedelass and @KristinLBradley
What:
You’ll review and approve PRs that update banner and image placement across our documentation pages. Each PR will follow these standards:
Each PR will include context and a summary of changes.
You’ll review alongside a design partner, ensuring both design and engineering teams are involved in each update.
📌 Summary
If merged, this PR will complete updates for the following component pages as part of the audit:
All other pages (7) total are okay with no changes needed.
🔗 External links
Jira ticket: HDS-4425
Google Sheet file: Here
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.