Upgrade major devDependenices
#2624
Open
+1,032
−969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dhaulagiri
reviewed
Dec 23, 2024
website/package.json
Outdated
| "ember-meta": "^2.0.0", | ||
| "ember-modifier": "^4.1.0", | ||
| "ember-page-title": "^8.2.3", | ||
| "ember-power-select": "^8.2.0", | ||
| "ember-prism": "^0.13.0", | ||
| "ember-prism": "^1.0.0", |
There was a problem hiding this comment.
noticed that this package is now archived, so we should create a ticket in our backlog to investigate other options...
There was a problem hiding this comment.
here is better alternative I recently used to replace ember-prism https://github.com/IgnaceMaes/ember-shiki
There was a problem hiding this comment.
I could have been more clear with my comment: I think the upgrade is fine but down the road we'll need to look at other options potentially
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR would upgrade most (exceptions detailed below)
devDependenciesto the latest major versions, and removejsdomfrom the websitedevDependencies.🛠️ Detailed description
These are upgrades for our tooling dependencies and do not require releases for our packages.
The intent is to merge this PR following the other upgrades listed below to avoid significant conflicts.
devDependencies#2623Exceptions:
ember-cli- Will be addressed in a separate update where theember-cliblueprint is updated as wellember-prism- Package is marked as archived, and alternatives will be researched separatelysvgo/svgr- related dependencies (we made a conscious decision to use v 1.x)@ember/test-waiters,@embroider/addon-dev,@embroider/test-setup,@glimmer/component,algoriasearch,del,ember-qunit,eslintember-a11y-refocus,ember-modifier,sassdependencies🔗 External links
Jira ticket: HDS-4251
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.