Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase .gts - Initial setup #2411

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Showcase .gts - Initial setup #2411

merged 6 commits into from
Sep 13, 2024

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Sep 12, 2024

📌 Summary

This PR does the initial setup of the showcase app, to be able to use the .gts file format for the <Shw::***> components.

🛠️ Detailed description

In this PR I have:

  • added necessary dev-dependencies:
    • ember-template-imports
    • prettier-plugin-ember-template-tag
    • @glint/environment-ember-template-imports
  • updated configuration files:

🔗 External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3828


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested review from aklkv, alex-ju, shleewhite and a team September 12, 2024 09:31
Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Sep 12, 2024 10:28am
hds-website ✅ Ready (Inspect) Visit Preview Sep 12, 2024 10:28am

@didoo didoo changed the title Showcase - Convert components to .gts - Initial setup Showcase.gts - Initial setup Sep 12, 2024
@didoo didoo changed the title Showcase.gts - Initial setup Showcase .gts - Initial setup Sep 12, 2024
Copy link
Collaborator

@aklkv aklkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, you will need linter and prettier changes but for the purpose of getting gts actually working this will do just fine 👍🏻

you might still needed after all https://github.com/hashicorp/design-system/actions/runs/10828172710/job/30042947081?pr=2412#step:7:16

@didoo
Copy link
Contributor Author

didoo commented Sep 12, 2024

Thanks @aklkv 🙏 for all the support in getting this PR and #2412 working

Base automatically changed from shw-components-remove-component-name to main September 12, 2024 14:46
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems happy, but I can't get it working locally, yarn run lint:js fails unexpectedly. @shleewhite have you encountered any issues?

Screenshot 2024-09-13 at 14 06 30

@shleewhite
Copy link
Contributor

CI seems happy, but I can't get it working locally, yarn run lint:js fails unexpectedly. @shleewhite have you encountered any issues?

@alex-ju nope... it it works for me - did you run yarn install first?
Screenshot 2024-09-13 at 9 13 36 AM

@alex-ju
Copy link
Member

alex-ju commented Sep 13, 2024

CI seems happy, but I can't get it working locally, yarn run lint:js fails unexpectedly. @shleewhite have you encountered any issues?

@alex-ju nope... it it works for me - did you run yarn install first? Screenshot 2024-09-13 at 9 13 36 AM

yep. don't mind me then, I'll find my way around – good to be merged!

@didoo didoo merged commit 5ccd8d4 into main Sep 13, 2024
16 checks passed
@didoo didoo deleted the showcase-gts/initial-setup branch September 13, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants