-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showcase .gts
- Initial setup
#2411
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.gts
- Initial setup.gts
- Initial setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, you will need linter and prettier changes but for the purpose of getting gts actually working this will do just fine 👍🏻
you might still needed after all https://github.com/hashicorp/design-system/actions/runs/10828172710/job/30042947081?pr=2412#step:7:16
c7ee68d
to
51e2be1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI seems happy, but I can't get it working locally, yarn run lint:js
fails unexpectedly. @shleewhite have you encountered any issues?
![Screenshot 2024-09-13 at 14 06 30](https://private-user-images.githubusercontent.com/788096/367306630-bfc0e16c-0fbd-4551-bfaa-538b92045004.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDY1NjAsIm5iZiI6MTczOTQwNjI2MCwicGF0aCI6Ii83ODgwOTYvMzY3MzA2NjMwLWJmYzBlMTZjLTBmYmQtNDU1MS1iZmFhLTUzOGI5MjA0NTAwNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwMDI0MjBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NzljYWRhYTNlZmM1OGIxZTY3ODEwZjI4NWNkNjM0ZWM4YWU0MWZhY2YxNGE5YjI1OWI5OTZjZWI4MTkwY2VjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.UBStTOmvowecSnORS5wnAy1pIvkdS7Nbw7uvu1oq4j4)
@alex-ju nope... it it works for me - did you run |
yep. don't mind me then, I'll find my way around – good to be merged! |
📌 Summary
This PR does the initial setup of the
showcase
app, to be able to use the.gts
file format for the<Shw::***>
components.🛠️ Detailed description
In this PR I have:
ember-template-imports
prettier-plugin-ember-template-tag
@glint/environment-ember-template-imports
.template-lintrc.js
file to avoid an issue with Prettier - taken from this change by @aklkvshowcase/.prettierrc.js file
per @aklkv setup hereember-template-imports
to glint environment intsconfig.json
🔗 External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3828
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.