Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added labels for redhat validation #22047

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Added labels for redhat validation #22047

merged 1 commit into from
Jan 3, 2025

Conversation

abhishek-hashicorp
Copy link
Contributor

Description

The CRT workflow is failing when promoting the redhat images for consul 1.20.2 release. Redhat have enforced the validations which requires the following labels to be present. These changes cater to those.

Link to failed promote workflow

Add the following labels to your Dockerfile or Containerfile: name, vendor, version, release, summary, description, maintainer and validate that they do not violate Red Hat trademark.

I can see there was an older PR which was trying to backport the changes to other versions but that seemed to have caused issues except in 1.20 hence doing the same here

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@abhishek-hashicorp abhishek-hashicorp added backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry labels Jan 3, 2025
@abhishek-hashicorp abhishek-hashicorp marked this pull request as ready for review January 3, 2025 06:46
@abhishek-hashicorp abhishek-hashicorp requested a review from a team as a code owner January 3, 2025 06:46
srahul3
srahul3 approved these changes Jan 3, 2025
View reviewed changes
Copy link

@srahul3 srahul3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@abhishek-hashicorp abhishek-hashicorp merged commit c1a887e into main Jan 3, 2025
110 of 114 checks passed
@abhishek-hashicorp abhishek-hashicorp deleted the update-image-tags-redhat branch January 3, 2025 07:21
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Jan 3, 2025
Merged
4 tasks
@abhishek-hashicorp abhishek-hashicorp added backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent labels Jan 6, 2025
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @abhishek-hashicorp! a backport is missing for this PR [22047] for versions [1.15,1.18,1.19] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@dhiaayachi dhiaayachi added backport/all Apply backports for all active releases per .release/versions.hcl and removed backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.20 Changes are backported to 1.20 backport/ent/1.19 Changes are backported to 1.19 ent labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srahul3 srahul3 srahul3 approved these changes

Assignees
No one assigned
Labels
backport/all Apply backports for all active releases per .release/versions.hcl pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishek-hashicorp @hc-github-team-consul-core @srahul3 @dhiaayachi