Skip to content

Commit

Permalink
Switch to NodeJS LTS 20 "Iron"
Browse files Browse the repository at this point in the history
NodeJS 18 "Hydrogen" will be EOL in April 2025, so we should switch to a
newer LTS. The latest LTS 22 "Jod" failed to build for me.

Closed #22065.

Signed-off-by: hashworks <[email protected]>
  • Loading branch information
hashworks committed Jan 10, 2025
1 parent c1a887e commit 3ecdb19
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:
- name: Setup with node and yarn
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: '18'
node-version: '20'
cache: 'yarn'
cache-dependency-path: 'ui/yarn.lock'

Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:
- name: Setup with node and yarn
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: '18'
node-version: '20'
cache: 'yarn'
cache-dependency-path: 'ui/yarn.lock'

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: '18'
node-version: '20'

- name: Install Yarn
run: corepack enable
Expand All @@ -57,7 +57,7 @@ jobs:

- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: '18'
node-version: '20'

- name: Install Yarn
run: corepack enable
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:

- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: '18'
node-version: '20'

- name: Install Yarn
run: corepack enable
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:

- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: '18'
node-version: '20'

- name: Install Yarn
run: corepack enable
Expand Down
2 changes: 1 addition & 1 deletion ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@
"ansi-html": "0.0.8"
},
"engines": {
"node": "18"
"node": "20"
}
}
4 changes: 2 additions & 2 deletions ui/packages/consul-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
"webpack": "^5.74.0"
},
"engines": {
"node": "18"
"node": "20"
},
"ember": {
"edition": "octane"
Expand All @@ -211,7 +211,7 @@
]
},
"volta": {
"node": "18"
"node": "20"
},
"dependencies": {
"doctoc": "^2.0.0",
Expand Down

0 comments on commit 3ecdb19

Please sign in to comment.