-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase speed sync with k8s #4384
base: main
Are you sure you want to change the base?
Conversation
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
Hi @v-kamerdinerov, the sync speed can be adjusted using the Is this suitable for your needs? |
Hello @blake That's something - thank you! However, my fix also allows synchronization when - registration is new or changed ConsulSyncPeriod I can reset to default, but my functional seems to be useful too. |
I may be mistaken but I thought thtat syncer already reacts as soon as endpoints are updated by use of the Informer? |
In addition to registering all services periodically, now sync new services as they appear, allowing to increase the full sync interval and reduce the overall number of catalog register call to Consul servers. |
Checked latest version - build was successful.
|
Changes proposed in this PR
In addition to registering all services periodically, now sync new services as they appear, allowing to increase the full sync interval and reduce the overall number of catalog register call to Consul servers.
This makes a difference for kube clusters with hundreds of instances without delaying updates.
How I've tested this PR
How I expect reviewers to test this PR
Checklist
CHANGELOG entry addednot needed