Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add k8s topology zone info for nodePort service #4301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add k8s topology zone info for nodePort service #4301

wants to merge 1 commit into from

Conversation

kolorful
Copy link
Contributor

@kolorful kolorful commented Sep 3, 2024 •
edited
Loading

Changes proposed in this PR

How I've tested this PR

  • Unit test
  • Running locally compiled version on a production Kubernetes cluster and verified it worked (see attached screenshot)
image

How I expect reviewers to test this PR

  • Same as how I tested

Checklist

@kolorful kolorful force-pushed the main branch 2 times, most recently from 04ebc1e to dc24ff2 Compare September 3, 2024 16:39
@kolorful kolorful marked this pull request as ready for review September 3, 2024 17:06
@kolorful kolorful requested a review from a team as a code owner November 18, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kolorful