DNS proxy helm chart #4164
Merged
DNS proxy helm chart #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhiaayachi
added
pr/no-changelog
dhiaayachi
commented
Jul 10, 2024
charts/consul/values.yaml
Outdated
| replicas: 1 | ||
|
|
||
| # Port number to be used by DNS proxy | ||
| port: 8700 |
There was a problem hiding this comment.
randomly chose a default port
jmurret
requested changes
Jul 12, 2024
jmurret
approved these changes
Jul 12, 2024
…ane image to pass those tests.
jmurret
force-pushed
the
dhiaayachi/NET-10193/dns-proxy-deployment
branch
from
e6102ed to
f54511d
Compare
jm96441n
pushed a commit
that referenced
this pull request
Jul 16, 2024
* adding templates * fix deployment to run the right container * remove the probes for the time being * align helm with the RFC * disable consul-dns service when dns proxy is enabled * add dns proxy enabled tests * revert adding tests for dns proxy as we need to have the right dataplane image to pass those tests. * change dns port to 8700 * fix dns-proxy to use global enable variable as well as dns.proxy.enabled * add bats tests * change port to 53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Adding helm chart templates for deploying DNS proxy, this include:
How I've tested this PR
Tested manually in an EKS cluster. This need to consul-dataplane with dns-proxy mode supported that will be added when hashicorp/consul-dataplane#571 is merged
Automated tests will be added when hashicorp/consul-dataplane#571 is merged in a later PR.
How I expect reviewers to test this PR
Checklist