fix ci errors

hashicorp · Jul 9, 2024 · 6814d9f · 6814d9f
1 parent 875df34
commit 6814d9f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/consuldp/consul_dataplane.go b/pkg/consuldp/consul_dataplane.go
@@ -96,7 +96,7 @@ func validateConfig(cfg *Config) error {
 	case cfg.Mode == ModeTypeSidecar && !strings.HasPrefix(cfg.XDSServer.BindAddress, "unix://") && !net.ParseIP(cfg.XDSServer.BindAddress).IsLoopback():
 		return errors.New("non-local xDS bind address not allowed")
 	case cfg.Mode == ModeTypeSidecar && cfg.DNSServer.Port != -1 && !net.ParseIP(cfg.DNSServer.BindAddr).IsLoopback():
-		return errors.New("non-local DNS proxy bind address not allowed when running as sidecar")
+		return errors.New("non-local DNS proxy bind address not allowed when running as a sidecar")
 	}
 
 	creds := cfg.Consul.Credentials

diff --git a/pkg/consuldp/consul_dataplane_test.go b/pkg/consuldp/consul_dataplane_test.go
@@ -12,6 +12,7 @@ import (
 
 func validConfig() *Config {
 	return &Config{
+		Mode: ModeTypeSidecar,
 		Consul: &ConsulConfig{
 			Addresses: "consul.servers.dns.com",
 			GRPCPort:  1234,
@@ -160,7 +161,7 @@ func TestNewConsulDPError(t *testing.T) {
 				c.DNSServer.BindAddr = "1.2.3.4"
 				c.DNSServer.Port = 1
 			},
-			expectErr: "non-local DNS proxy bind address not allowed",
+			expectErr: "non-local DNS proxy bind address not allowed when running as a sidecar",
 		},
 		{
 			name: "no bearer token or path given",