test(e2e): Add test for connect http
#5423
Merged
+108
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
requested changes
Jan 8, 2025
testing/internal/e2e/tests/base/target_tcp_connect_http_test.go
Outdated
Show resolved
Hide resolved
| require.NoError(t, err) | ||
| _, err = f.Write([]byte(fmt.Sprintf("while true; do nc -l -p %s -q 1 < somepage.html; done\n", destPort))) | ||
| require.NoError(t, err) | ||
| _, _ = io.Copy(io.Discard, f) // Not checking error here since it fails in CI for some reason |
There was a problem hiding this comment.
The theory: since the command being executed is an infinite loop, this ends up returning an error on session cancellation during cleanup since the command was interrupted.
testing/internal/e2e/tests/base/target_tcp_connect_http_test.go
Outdated
Show resolved
Hide resolved
moduli
force-pushed
the
moduli-e2e-connect-http
branch
from
857c075 to
b2f7056
Compare
johanbrandhorst
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an e2e test for the usage of
boundary connect http.The way this is achieved is a little roundabout. The test first connects to the SSH target and enables port forwarding. It then kicks off a process on a target to start a simple web server. Finally, the test creates a new target pointing to the web server and performs a
connect http.https://hashicorp.atlassian.net/browse/ICU-10838