Bug: fix groups in children scopes being filtered out by grants #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
previously approved these changes
Jan 9, 2025
elimt
previously approved these changes
Jan 9, 2025
bosorawis
force-pushed
the
bosorawis-bug-fix-list-resource-filtering-out-children-scope
branch
from
f3ade6c to
d195247
Compare
johanbrandhorst
previously approved these changes
Jan 20, 2025
ddebko
previously approved these changes
Jan 22, 2025
set the `ParentScopeId` before fetching authorized actions for alias
set the `ParentScopeId` before fetching authorized actions for worker
* fix(user): children scopes being filtered out by grants for user Resources are being filtered out due to missing ParentScopeId when constructing Resource to pass into authResults.FetchActionSetForId.
set the `ParentScopeId` before fetching authorized actions for worker
set the `ParentScopeId` before fetching authorized actions for target
* fix(roles): set parent scope id for roles resource set the `ParentScopeId` before fetching authorized actions for role resource
* fix(managed-group): set parent scope id for managed-group resource set the ParentScopeId before fetching authorized actions for managed resource
set the `ParentScopeId` before fetching authorized actions for host resource
set the ParentScopeId before fetching authorized actions for host-set resource
set the ParentScopeId before fetching authorized actions for host-catalog resource
…rce (#5458) set the ParentScopeId before fetching authorized actions for credential-store resource
* handlers/authmethods: fix children permission * documentation * formatting
set the `ParentScopeId` before fetching authorized actions for credential resource
* handlers/accounts: fix children grants filtering out results unexpectedly * make gen
* fix authtokens not passing children scope ID * make gen
… fetching action sets (#5467) * fix(common) set parent ID before fetching action sets * make gen * additional test * rename test * more tests * remove duplicate test * make gen
bosorawis
force-pushed
the
bosorawis-bug-fix-list-resource-filtering-out-children-scope
branch
from
bf4a4c3 to
72892f2
Compare
tmessi
previously approved these changes
Jan 24, 2025
Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
johanbrandhorst
approved these changes
Jan 24, 2025
bosorawis
deleted the
bosorawis-bug-fix-list-resource-filtering-out-children-scope
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources are being filtered out due to missing
ParentScopeIdwhen constructingResourceto pass intoauthResults.FetchActionSetForId. This PR includes adding utility functions to help with setting up proper authorization