Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cluster): check worker status multiple times #5393

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

ddebko
Copy link
Collaborator

@ddebko ddebko commented Dec 20, 2024

Summary

The cluster session cleanup test would fail randomly due to a worker status context deadline timeout. This update fixes the flaky test by checking the worker status multiple times using a require.Eventually check.

@ddebko ddebko requested a review from a team as a code owner December 20, 2024 22:36
@github-actions github-actions bot added the core label Dec 20, 2024
@johanbrandhorst johanbrandhorst changed the title test(cluster): check worekr status multiple times test(cluster): check worker status multiple times Dec 23, 2024
@johanbrandhorst johanbrandhorst added this to the 0.19.x milestone Dec 23, 2024
@ddebko ddebko merged commit dd1482b into main Dec 23, 2024
61 of 64 checks passed
@ddebko ddebko deleted the ddebko-stability branch December 23, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants